Improve PlaybackContainer (and rename to PlaybackControl) #1563

peppy · 2017-11-22T03:04:59Z

Unsure how it got merged in the previous state.

Adds TestCase.
Brings design up-to-date.
Fixes leading spaces before % symbol on some cultures.
Removes usage of AlwaysPresent.
Removes 25% tempo option. Sounds bad with current implementation and should not be used for timing anyway.

Also self-contains the tab options inside the tab control.

peppy added 10 commits November 22, 2017 10:54

Bindables should be readonly

63d366e

Clean up state change logic

461c8e8

Rename weird method

c06d6d0

Fix leading space before percent sign

855acc9

Remove need for AlwaysPresent

ff5404e

Also self-contains the tab options inside the tab control.

Rename to PlaybackControl and add a TestCase

0f8499c

Update colours to match design

27fb598

Tidy some regressions

e3c5a59

Reorder methods

36d45f6

Fix license header from wrong project

757bb69

peppy added the type:code-quality label Nov 22, 2017

peppy added this to the November 2017 milestone Nov 22, 2017

smoogipoo approved these changes Nov 22, 2017

View reviewed changes

smoogipoo and others added 2 commits November 22, 2017 18:21

Merge branch 'master' into fix-playback-control

4cbdd97

Merge branch 'master' into fix-playback-control

95275cd

peppy merged commit 095cc44 into ppy:master Nov 22, 2017

peppy deleted the fix-playback-control branch November 22, 2017 11:04

Provide feedback