Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ruleset's ShortName for mod caching purposes #15736

Merged
merged 3 commits into from
Nov 22, 2021

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Nov 22, 2021

OnlineID is only present for legacy rulesets (for the time being). Going forward, ShortName is the unique identifier for mods.

@peppy
Copy link
Sponsor Member Author

peppy commented Nov 22, 2021

Weird test failures, I don't get them locally.

@peppy peppy added the realm deals with local realm database label Nov 22, 2021
@bdach bdach merged commit d9db3b9 into ppy:master Nov 22, 2021
@peppy peppy deleted the ruleset-use-short-name branch November 23, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
realm deals with local realm database size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants