Add owner avatar to multiplayer playlist items #15801
Conversation
| room.Playlist[i].ID = currentPlaylistItemId++; | ||
| room.Playlist[i].OwnerID = room.Host.Value.OnlineID; |
There was a problem hiding this comment.
As evidenced by the test failures, it appears some tests create rooms without a host.
| @@ -191,12 +203,21 @@ protected override Drawable CreateContent() | |||
| { | |||
| new Drawable[] | |||
| { | |||
| ownerAvatar = new OwnerAvatar | |||
There was a problem hiding this comment.
Adding the avatar at this level means that it will also appear in playlists with the room creator as the owner of all playlist items, which feels unintended / somewhat of a waste of space:
Are there any plans regarding that going forward, or is that just an oversight?
There was a problem hiding this comment.
Feels like it definitely shouldn't be present in all but the multiplayer queue context.
| }); | ||
| } | ||
|
|
||
| public LocalisableString TooltipText => User == null ? "loading user..." : $"queued by {User.Username}"; |
There was a problem hiding this comment.
The "loading user" text appears incorrectly in some contexts. For instance, the screenshot below was taken during creation of a new multiplayer room:
|
Also, not to put too much of a point on what is probably mostly a temporary design, but I'm a bit weirded out by the avatars being on the left. It feels like they are not nearly important enough information to be the the first thing on a playlist item. Maybe they would fare better as the rightmost thing on the item?
|
|
All above issues should be fixed. Avatars will also only be displayed in the subscreen's playlist and no longer in Playlists or the settings overlay. |
Should probably be replaced with a loading spinner in the future, don't really like "loading" tooltips.
2021-11-25.23-27-07.mp4