New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make leaderboard tabs and active ruleset filter scores #1599
Merged
Merged
Changes from 24 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
fe559f4
Add respective query params to GetScoreRequest based on selected tab.
naoey a58bd72
Add placeholder when there are no scores.
naoey 487483e
Move loader hiding to a better place.
naoey 096e98b
Add game mode query to request.
naoey b6de1ce
Handle query params better.
naoey c5a78e5
Add a retry button for when scores request fails.
naoey e723e66
Merge remote-tracking branch 'upstream/master' into leaderboard-scopes
naoey 0b3f755
Don't break VisualTests and add a real beatmap step.
naoey ae9ce2f
Unbind ruleset event from leaderboard.
naoey f4f732c
Remove unnecessary null check and tweak transform a bit.
naoey b261d32
Put retry button in a BeatSyncedContainer and change error message.
naoey 4212315
Use a single placeholder container for empty and retry.
naoey ae201f0
R#
naoey ac1fb51
Fix line endings and derp that was causing request failures.
naoey e832f16
Add failure test case.
naoey a30cd42
Make retry button not look drunk.
naoey ccbbd09
Merge remote-tracking branch 'upstream/master' into leaderboard-scopes
naoey 47bd973
Use ShortName for mode.
naoey 21829ba
Merge branch 'master' into leaderboard-scopes
peppy 63dce59
Throw an exception if we try and retrieve local scores online
peppy 1b91f24
Simplify scope logic
peppy c871a25
Remove unnecessary constructure and make ruleset required
peppy 3292ef3
Fix test edge cases
peppy 6d471da
Remove unnecessary workaround
peppy 23f4799
Create placeholder classes instead of changing Children.
naoey c8c8b68
Kill ugly retry button bounce.
naoey 8d24a04
Remove unused usings.
naoey 85dee3a
Increase GetScoresRequest timeout & leave existing scores when API dies.
naoey 2ff351c
Show retrieval failure when OnlineBeatmapID is missing
peppy afcb991
Reorder API / logged in checks to make more sense
peppy 01c4b1e
Maintain a placeholder state and add tests showing all the states.
naoey 63f2436
Merge branch 'master' into leaderboard-scopes
peppy 644aaa8
Unsubscribe from API state change event.
naoey 4bd2c7e
Fix minor formatting issue
peppy 65e6206
Use local bindable
peppy 57fdbda
Remove unnecessary IsLoaded check
peppy 40ceaf1
Merge branch 'master' into leaderboard-scopes
peppy 5c9d484
Adjust debounce a bit
peppy aa38888
Adjust animation slightly
peppy File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as off-topic.
Sorry, something went wrong.