Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash during kiai section on specific map due to negative transform duration #17150

Merged
merged 2 commits into from Mar 10, 2022
Merged

Fix crash during kiai section on specific map due to negative transform duration #17150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a02adfd
Fix crash on super high bpm kiai sections
SiimPender Mar 7, 2022
a1b7bf3
Use a minimum fade length for clamping rather than zero
peppy Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion osu.Game.Rulesets.Osu/Skinning/Default/KiaiFlash.cs
View file
Open in desktop
@@ -1,6 +1,7 @@
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.

using System;
using osu.Framework.Audio.Track;
using osu.Framework.Graphics;
using osu.Framework.Graphics.Shapes;
Expand Down Expand Up @@ -37,7 +38,7 @@ protected override void OnNewBeat(int beatIndex, TimingControlPoint timingPoint,
Child
.FadeTo(flash_opacity, EarlyActivationMilliseconds, Easing.OutQuint)
.Then()
.FadeOut(timingPoint.BeatLength - fade_length, Easing.OutSine);
.FadeOut(Math.Max(fade_length, timingPoint.BeatLength - fade_length), Easing.OutSine);
}
}
}