New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix supporter icon appearing incorrectly in user profile header #1747

Merged
merged 2 commits into from Dec 25, 2017

Conversation

2 participants
@Aergwyn
Member

Aergwyn commented Dec 25, 2017

I noticed 2 problems with it.
a) It was missing the background.
b) It was always showing regardless if you were supporter or not.

fix supporter icon in profile missing its background
also it doesn't show up on profiles without supporter anymore
@@ -328,7 +310,8 @@ private void loadUser()
Depth = float.MaxValue,
}, coverContainer.Add);
if (user.IsSupporter) supporterTag.Show();
if (user.IsSupporter)
SupporterTag.Show();

This comment has been minimized.

@peppy

peppy Dec 25, 2017

Member

does this not need a hide?

@peppy

peppy Dec 25, 2017

Member

does this not need a hide?

This comment has been minimized.

@Aergwyn

Aergwyn Dec 25, 2017

Member

The ProfileHeader is currently recreated with each user that is to be shown if I read this correctly.

@Aergwyn

Aergwyn Dec 25, 2017

Member

The ProfileHeader is currently recreated with each user that is to be shown if I read this correctly.

This comment has been minimized.

@peppy

peppy Dec 25, 2017

Member

I see.. kinda weird it has a user property in the first place then but let's go with it

@peppy

peppy Dec 25, 2017

Member

I see.. kinda weird it has a user property in the first place then but let's go with it

@peppy peppy added this to the December 2017 milestone Dec 25, 2017

fix formatting and test
add missing line
@peppy

peppy approved these changes Dec 25, 2017

@peppy peppy changed the title from Fix supporter icon in profile header to Fix supporter icon appearing incorrectly in user profile header Dec 25, 2017

@peppy peppy merged commit 3670901 into ppy:master Dec 25, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Dec 25, 2017

Member

👍

Member

peppy commented Dec 25, 2017

👍

@Aergwyn Aergwyn deleted the Aergwyn:fix-profile-supporter-icon branch Dec 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment