Fix supporter icon appearing incorrectly in user profile header #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also it doesn't show up on profiles without supporter anymore
peppy
reviewed
Dec 25, 2017
| private void checkSupporterTag(bool isSupporter) | ||
| { | ||
| AddUntilStep(() => profile.Header.User != null, "wait for load"); | ||
| if(isSupporter) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
peppy
reviewed
Dec 25, 2017
| @@ -328,7 +310,8 @@ private void loadUser() | |||
| Depth = float.MaxValue, | |||
| }, coverContainer.Add); | |||
|
|
|||
| if (user.IsSupporter) supporterTag.Show(); | |||
| if (user.IsSupporter) | |||
| SupporterTag.Show(); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
add missing line
Aergwyn
force-pushed
the
fix-profile-supporter-icon
branch
from
336ba19
to
48e55a0
Compare
peppy
approved these changes
Dec 25, 2017
peppy
changed the title
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed 2 problems with it.
a) It was missing the background.
b) It was always showing regardless if you were supporter or not.