Fix result page from leaderboards not sorting hitcounts correctly #1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rather than making a new enum, how about using |
|
Sure. I could use that. Can I additionally move it into Scoring namespace then? Would probably make more sense for it to be there. Then it's not DrawableHitObject and Judgement only anymore. |
|
Yep |
HitCount was good to bad but HitResult is the opposite. To account for this just descending order on the result page.
peppy
approved these changes
Dec 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the liberty to replace all the strings with an enum which also made it easier to sort it. It now shouldn't matter in which order the statistics are added.
Closes #1809