Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility issues with legacy Catmull sliders #18321

Merged
merged 2 commits into from
May 19, 2022

Conversation

smoogipoo
Copy link
Contributor

Fixes #18308

@smoogipoo smoogipoo added the area:beatmap-parsing .osu file format parsing label May 18, 2022
@bdach
Copy link
Collaborator

bdach commented May 18, 2022

Appears to work, but I'll leave one (rather obvious) observation: resolving the issue in this manner makes saving catmull sliders in lazer editor a potentially lossy operation (and one that is lossy in a way that is currently not communicated to the user), i.e. if I modify and save any of the maps mentioned in the issue, the catmull sliders will regress to their broken linear form. I'm not expecting this to be addressed here myself, leaving more as food for thought.

@bdach bdach requested a review from peppy May 18, 2022 20:55
@peppy
Copy link
Sponsor Member

peppy commented May 19, 2022

resolving the issue in this manner makes saving catmull sliders in lazer editor a potentially lossy operation

I touched on this when proposing this solution in voice. The way I see it, all curves that are multi-segment on lazer are affected by this. The eventual plan would be to either better communicate this limitation, or implement limited support for the new curve types in stable (for gameplay, not editing) to allow for backwards compatibility.

The second is more likely, and when this is done, stable would use a new pathway that correctly handled multi-segment catmull implicitly. Which is another reason I wanted to keep this isolated to the legacy converter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:beatmap-parsing .osu file format parsing size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difference between sliders in lazer and stable
3 participants