Fix Catmull slider parsing with duplicate initial point #18386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18366
Lazer by default adds a
(0, 0)control point to the front of the list. But sometimes, especially from older maps, sliders are allowed to contain the slider's position as the first control point. This doesn't have any effect to the overall shape of the slider if it is correctly de-duped, and lazer wasn't de-duping correctly after my previous changes.I was aware of this quirk while working on the original changes prior to their final refactored form (see code sample in #18308 (comment)).
I can do a diffcalc spreadsheet upon request, but I don't expect it to be meaningful.