Update beat snap divisor control to be more in line with new designs #18393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you show how this actually looks in |
|
The intended use is for the designs as per figma:
But I do understand your point. I figured that we would want these ratios available, even if that are applied at different multipliers in each location.
This is how it currently looks. Not 100% happy but it's something. |
|
I've pushed the actual design to this PR as it doesn't make much sense to leave it stand-alone at this point. Best consume as a whole. |
peppy
changed the title
smoogipoo
previously approved these changes
May 24, 2022
3 tasks
|
I've pushed a change to cache some more |
bdach
approved these changes
May 24, 2022
smoogipoo
approved these changes
May 25, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this doesn't match figma 100%. This is just focused on getting it to fit with the surrounding controls for now, proportionally and corner radius-ly.