Wait for and dismiss notification in editor navigation test #18910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to address test flakiness (see: https://discord.com/channels/188630481301012481/188630652340404224/991009407645143072)
In the end of the day I don't think the first run overlay trail amounts to anything. If it was it interfering, then there should be a "click to resume first run setup" notification somewhere in the log output, but there is not.
I did however notice in debugging that if unlucky, the "import successful" completion notification in this particular test could be shown as late as inside the editor, which means that it visually obscures the gameplay test button, which makes the test get stuck in editor. To that end, this change makes it so that the test waits for the notification to show in song select, and dismisses the sidebar there to prevent it from meddling further later.
Maybe bit of a "left field" solution but I'm not sure I've got anything better to offer at this point in time.