Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky tests not running at all with environment variable set #19021

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Fix flaky tests not running at all with environment variable set #19021

merged 1 commit into from
Jul 7, 2022

Conversation

frenzibyte
Copy link
Member

@frenzibyte frenzibyte commented Jul 7, 2022 •
edited
Loading

As per documentation and confirmation on discord:

The argument you specify is the total number of attempts and not the number of retries after an initial failure.

@peppy peppy enabled auto-merge July 7, 2022 01:28
@peppy peppy merged commit e5dd7b1 into ppy:master Jul 7, 2022
@frenzibyte frenzibyte deleted the fix-flaky-tests-envvar branch July 7, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppy peppy peppy approved these changes

Assignees
No one assigned
Labels
size/XS type:testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frenzibyte @peppy