Fix spectator client not correctly reconnecting after shutdown #19187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching servers over, I've notice a disparity in connections switching to the new spectator server (via datadog metrics). Users' clients would be stuck on the old spectator hub but also unable to make new spectator sessions.
Turns out this is due to incorrect use of
SendAsync
instead ofInvokeAsync
. The former does not block, nor propagate exceptions.I'm not sure about the remaining
SendAsync
usage inSpectatorHub
. We may want to switch them over as well.I've tested this manually to work as expected.