Better handling CheckModsAllowFailure

[cdwcgt]

close #20511

It was thought that this would affect mod like autoplay but IncompatibleMods will aviod it

[Flan-Fan]

A thing that I forgot to mention in the original post is that I somehow managed to get a 100 while not failing while attempting to record the problem. Here's a YouTube video of that

[cdwcgt]

A thing that I forgot to mention in the original post is that I somehow managed to get a 100 while not failing while attempting to record the problem. Here's a YouTube video of that

Note that by default EZ has three chances to fail

One used when first miss, second is 100

then you failed in the third

[bdach]

This change makes the following statement in xmldoc false.

osu/osu.Game/Rulesets/Mods/IApplicableFailOverride.cs

Line 14 in bfafb44

/// <returns>Whether the fail should be allowed to proceed. Return false to block.</returns>

Also I'm not convinced that this is the right change to make. If the interface's goal is to prevent failure, it arguably shouldn't get overridden by other mods when multiple fail-deciding mods are active.

The actual problem here is that there are multiple mods trying to affect failure in the first place and the interface isn't properly designed for that. I worry that trying to fix this is going to reintroduce the problem of adding mod combination specific logic.

Maybe there's a chance this could be fixed at a higher level by reformulating how ModWithExtraLives works (i.e. lift the extra lives logic out of IApplicableFailOverride into the health processor), but I'm not sure that's the right direction either.

[cdwcgt]

I also think there are some issues with this change, but it seems all are prevented by incompatibilities between mods

Failing while triggering the condition of sd or pf(or all failcondition) is definitely the highest priority (in currently compatible mod combinations

or I think we can do more judge like 'force fail'

For a problem of this pr is NF will faill if Ez open and run out extra life

[cdwcgt]

I thought about another possibility of adding the "allowFail" method (or attributes) to the interface.
It is designed to define whether this game session can fail.

If one of the mods is defined it as false, then this session will not allow to fail(for ModBlockFail)

Then the other reservations are as it is.

[cdwcgt]

I decide to create a enum to deal with three situations

1. All combinations with NF: NF It should be unquestionably unfailable, so it return BlockFail and will handle first. all IApplicableFailOverride should incompatible with its to avoid problem
2. All combinations with SD PF: They should ignore other mod status to trigger failures if eligible, they are incompatible with ModBlockFail.
3. last case for other mod with extra life: should not block ForceFail when they fail to block because they are eligible.

so if one of mod return BlockFail, fail will not perform and will not check other condition, and then if one of mod return ForceFail, it will handle fail although other mods want to avoid it.
at last all mod are AllowFail, fail will perform

[smoogipoo]

Without XMLDocs I can't tell what AvoidFail does.

[cdwcgt]

xmldoc has been added