Compute lifetime start from entry for scrolling hit objects #20570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
reviewed
Oct 4, 2022
| @@ -23,10 +23,6 @@ public abstract class DrawableManiaHitObject : DrawableHitObject<ManiaHitObject> | |||
|
|
|||
| protected readonly IBindable<ScrollingDirection> Direction = new Bindable<ScrollingDirection>(); | |||
|
|
|||
| // Leaving the default (10s) makes hitobjects not appear, as this offset is used for the initial state transforms. | |||
| // Calculated as DrawableManiaRuleset.MAX_TIME_RANGE + some additional allowance for velocity < 1. | |||
| protected override double InitialLifetimeOffset => 30000; | |||
There was a problem hiding this comment.
I think this will provide quite a good performance boost in mania due to less notes being alive. (did a quick check but hard to say due to the old behaviour actually limiting the upper number of objects in a weird way).
|
Can confirm this also fixes edge cases in osu!mania Before: osu.2022-10-04.at.07.37.36.mp4After: osu.2022-10-04.at.07.38.28.mp4 |
peppy
approved these changes
Oct 4, 2022
smoogipoo
approved these changes
Oct 5, 2022
|
@ekrctb it seems like this change has regressed head notes in mania holds somehow: without this PR: osu.Game.Rulesets.Mania.Tests.2022-10-06.at.10.08.35.mp4with this PR: osu.Game.Rulesets.Mania.Tests.2022-10-06.at.10.06.45.mp4 |
This was referenced Oct 6, 2022
This was referenced Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16440