Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Manual .sln and .csproj migration for VS2017 (Windows) compatibility #2139

Closed
wants to merge 2 commits into from

Conversation

FreezyLemon
Copy link
Contributor

VS2017 wanted to migrate the .sln files (because of "Visual Studio 2012" in the header) and the .csproj files (because of the iOS.props Import not being at the top and somehow not working properly).

Automatic migration broke a lot of stuff though, so I did it manually. VS2017 still changes a lot of things when loading, but most are just "cosmetics" like rearranging build configs.

One of the devs on Mac should test this to see if it opens and builds properly.

Also fixes files not displaying bc of <Import> not working when at end of Project declaration
@Frontear
Copy link
Contributor

Frontear commented Mar 5, 2018

I'm curious as to why this would benefit. Xamarin building for iOS requires a MAC, and if you own a mac, you may as well be cloning and building on the mac as is. Windows users just can't do anything useful with this.

@FreezyLemon
Copy link
Contributor Author

@Frontear Multiple things:
Xamarin.iOS builds do not require a Mac, though testing them does require one (or an iPhone, not sure). This also has virtually no negative effects on Mac users if done right, as I will be leaving minor (non breaking) changes that only VS on Windows makes uncommited.

As to why I would want to fix this, there are two main reasons:

  1. It is currently planned to merge most (or all) branches into master, which would include iOS. I'd like to think that it would be nice to have the .iOS.sln files working on windows aswell when this happens.
  2. Mobile development on Android is also going to happen, and it's very possible that there's some shared code between the two mobile platforms, in which case it would be nice to access the iOS stuff on windows.

also update osu-resources project GUID
@FreezyLemon
Copy link
Contributor Author

This gives a bit more context on what's going on here, by the way. It seems the project GUID that is currently used is a legacy option, and the one I replaced it with is for newer .NET Core projects (like the ones we are using so the project finds the files to compile without explicit declaration).

@smoogipoo
Copy link
Contributor

Prior to this, we need to update the iOS branch with the latest master changes since netstandard has brought a few sln changes.

Feel free to do so and apply these sln changes both on master and on the iOS branches (and then re-PR). Closing this one for now.

(Preferrably apply on master first).

@smoogipoo smoogipoo closed this Apr 2, 2018
@FreezyLemon FreezyLemon deleted the ios-fix-csproj-vs2017 branch April 2, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants