Fix osu! logo not being draggable on player loader

[Joehuu]

• Addresses Gameplay transition screen's osu! logo is no longer draggable #22038

[frenzibyte]

This looks fine to me, but I'll wait for a second opinion on whether to go with the first or second solution mentioned in #22038 (reply in thread), especially since this is now affecting non-event methods as well (the change in OnNewBeat), didn't notice it initially.

[bdach]

To be brutally honest I am utterly baffled as to why time is even being spent on this, which was why I deliberately ignored the discussion thread. And the logo not being draggable in this context is arguably more correct behaviour to me. Finally I'm not sure why "dragging the logo used to prevent the transition screen from passing" is an actual behaviour anyone should depend on.

Abstain from review. If it was up to me, I'd close this PR and resolve the discussion as "wontfix".

[frenzibyte]

I didn't focus much on the discussion thread but I found dragging being blocked by the logo not performing anything on click sounded very wrong, so I felt this solution would be pretty much okay.

[Walavouchey]

To be brutally honest I am utterly baffled as to why time is even being spent on this, which was why I deliberately ignored the discussion thread. And the logo not being draggable in this context is arguably more correct behaviour to me.

to me the same thing could be said about the draggable logo feature in general, but as it stands this small easter egg was undermined unintentionally as a side effect of another fix. i have no idea why dragging the cookie should work everywhere except for this one screen. would you have said the same if say winding up the cursor in menus didn't work anymore?

I'm not sure why "dragging the logo used to prevent the transition screen from passing" is an actual behaviour anyone should depend on

indeed no one depends on that, but if one were to discover that you can drag the cookie on this screen they'd otherwise be rudely interrupted

not that i was demanding anyone to pay attention to this, but i hope where i'm coming from doesn't sound too outlandish

[bdach]

i have no idea why dragging the cookie should work everywhere except for this one screen

Because on main menu the cookie does something when clicked. In the loader it doesn't.

But that's mostly beside the point. My main point is that I don't want to be spending time arguing this.

[peppy]

Quite subjective, but having it draggable in all contexts is very important to me. The behaviour of the logo is one of the core mechanics of the UI to me.

[peppy]

Why is this a false return versus the true below? Seems weird.

[frenzibyte]

Yeah I'm not sure on whether the logo should block components behind it or not, but since the current result matches how it behaved previously, I overlooked it as to not be nit-picky.

[peppy]

I think I'd rather it's consistent here.

[frenzibyte]

I believe this also includes other events, since they're inconsistent right now. No?

[peppy]

I've updated the return types of the other events, and adjusted the animations slightly (to play more even when there's no action). Feels good to me.