Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GameplaySampleTriggerSource not considering nested objects when determining the best sample to play #22659

Merged
merged 10 commits into from Feb 22, 2023
Merged

Fix GameplaySampleTriggerSource not considering nested objects when determining the best sample to play #22659

merged 10 commits into from Feb 22, 2023

Commits on Feb 16, 2023

  1. Add test coverage of GameplaySampleTriggerSource not considering ne… 

    …sted objects
    @peppy
    peppy committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    b59ec55 View commit details
    Browse the repository at this point in the history

  2. Fix GameplaySampleTriggerSource not considering nested objects when… 

    … determining the best sample to play
    @peppy
    peppy committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    affa950 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fix-taiko-drum-nested-sample-detection

    @bdach
    bdach committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    2fdf1fd View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. Change early return to also find the earliest nested object

    @peppy
    peppy committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    19d5293 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Merge branch 'master' into fix-taiko-drum-nested-sample-detection

    @peppy
    peppy committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    5ba6059 View commit details
    Browse the repository at this point in the history

  2. Add wait steps to ensure frame-stable clock has caught up before chec… 

    …king state
    @peppy
    peppy committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    e686b43 View commit details
    Browse the repository at this point in the history

  3. Update slider sample source asserts to match expected behaviour 

    As pointed out in review, if the current time is after the end of the
slider, the correct hit object to use for sample retrieval is the object
itself, not any nested object.
    @peppy
    peppy committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    9321ec2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into fix-taiko-drum-nested-sample-detection

    @bdach
    bdach committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    3d2fcb0 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. Seek using GameplayClockContainer

    @peppy
    peppy committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    a511e64 View commit details
    Browse the repository at this point in the history

  2. Update assertion to also check GameplayClockContainer's current time

    @peppy
    peppy committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    f61fbcf View commit details
    Browse the repository at this point in the history