Fix GameplaySampleTriggerSource not considering nested objects when determining the best sample to play
#22659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… determining the best sample to play
peppy
force-pushed
the
fix-taiko-drum-nested-sample-detection
branch
from
fe6c13a
to
affa950
Compare
bdach
reviewed
Feb 16, 2023
bdach
requested changes
Feb 17, 2023
As pointed out in review, if the current time is after the end of the slider, the correct hit object to use for sample retrieval is the object itself, not any nested object.
|
Curious windows-only test failures here that I initially failed to spot... Something related to clock offsets? |
|
Yeah this is most definitely the windows-specific extra 15ms of offset: I guess all seeks should be using |
bdach
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we correctly support this at a decoding level, the special case of taiko / mania playing back samples in a non-standard method meant that things would fall apart there.
This manifests in beatmaps which adjust sample sets or volumes mid-object (think osu!taiko drum roll or osu!mania hold notes), where the actual playback would not respect these adjustments.
GameplaySampleTriggerSourcetest to not be realtime dependent #22658.See https://github.com/ppy/osu-wiki/pull/8791/files#r1106839986.
Also mentioned on #17247.
Can test using: Kenji Ninuma - DISCOPRINCE (peppy).osz.zip