-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mod search #23414
Add mod search #23414
Conversation
The shortcut key of “deselect all” is backspace, which should be blocked when using the search box. osu.framework.running._osu-development_.2023-05-07.01-23-28_x264.mp4ps: I changed |
@cdwcgt this bug now fixed and have test coverage (see |
For the UX of this feature, I'd expect a few things:
|
It already does
I think it should be always first as sometimes mod search shows multiple modes even when you fully entered the mod name. Also, It would be better to select/deselect on enter. (What about doing it on hitting search button as well? 🤔)
This one is what I can't decide. I like the idea of having search always focused and just changing the hotkeys, as it's a better UI option. Yet changing the hotkeys makes the setting useless as all the hotkeys can be used with active search. Need to mention that the focus logic is already done (also have test coverage), so changing the search to always focused means that the logic needs to be reverted. And now it's either adding useless option to the settings or revert some progress. @peppy, any thoughts on this? Current search focus logic showcasesearchBoxFocusShowcase.mp4 |
Just to confirm, is this PR dependent on ppy/osu-framework#5772? |
Yes, unless everyone is ok with calling |
`Bindable` has one of those already.
- Was on wrong ruleset, so the mod/free mod sets did literally nothing - `assertHasFreeModButton` had a param that did nothing - Was checking `MatchingFilter` rather than `Visible`
Universally disliked. `!= false` is preferred.
Was preventing mod preset panels from refiltering correctly on ruleset change due to the `matchingFilter == value` guard.
I've pushed a whole bunch of changes here. @Cootz please read through them and keep this sort of stuff in mind for future contributions. If there is something that is unclear in the changes that I've made then please let me know. @peppy I think I've cleaned this up as best as I can, so that this can be considered for merging for next release. There's still a whole bunch of hacks here to work around various issues with |
Done primarily to keep mod hotkeys working without any behavioural changes when mod select is opened.
As discussed in #22893 this PR adds search bar to mod overlay
Showcase
ModSearchShowcase.mp4
Need advice
I'm not a designer so I need some help with defining optimal location for the search bar on both
UserModSelectOverlay
andFreeModSelectOverlay
(especially last one).Also animation at this state are quite rude (panels and columns just disappear from overlay) so I would like to get some help there as well.