Change mapping delete key to shift+delete to allow binding delete key #2375
Conversation
|
If anything, this is backwards and removing existing bindings should be done using We may be better off designing the UI to have a button to unbind as well, for cases where a keyboard is not available. |
|
You didn't update the label to match. |
|
Label updated. I also adjusted the overlay width. Not sure how you would have preferred to do that - I changed the width only of KeyBindingOverlay instead of SettingsOverlay. |
peppy
changed the title
| @@ -198,18 +198,22 @@ protected override bool OnKeyDown(InputState state, KeyDownEventArgs args) | |||
| if (!HasFocus) | |||
| return false; | |||
|
|
|||
| switch (args.Key) | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| @@ -12,6 +12,8 @@ namespace osu.Game.Overlays | |||
| { | |||
| public class KeyBindingOverlay : SettingsOverlay | |||
| { | |||
| protected const float WIDTH = 430; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
peppy
changed the title
|
In the process of fixing that last piece, I discovered a framework-level issue (ppy/osu-framework#1552) but as this is completely irrelevant to this PR and already existed before it, this should be fine to go through with 👍. |
This is my solution for Issue #2363. Delete key still deletes key binding, but you can now bind it by
alt+deletekey combination. In addition to that, now it is possible to assign any key combination with Delete key exceptalt+delete.One thing I'm not sure about is to where it should be documented.