Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Make BeatmapSetOverlay accept nulls everywhere #2416
A step forward in usability of
Helps with making #2350 tidy.
referenced this pull request
Apr 18, 2018
Reviewing one class or class group at a time would make this so much simpler.
The avatar change is grouped into all of this, changes to how things are displayed in SuccessRate are grouped into all of this, changes to display and interaction of things like Beatmap in ScoresContainer are grouped into all of this.
None of these components have been tested individually, so there's a lot of cases I have to go through to validate the code visually.