Add an "Adjust pitch" switch to DT/HT

[Givikap120]

Adjust pitch switch in DoubleTime and HalfTime mods.
Also Nightcore and Daycore is now inherit from RateAdjust.

[rszyma]

Sorry not sorry for bumping this. I'd love to see this finally added. Is there anything holding back this PR?

[peppy]

I'm still not sure I like what this does to the mod inheritance. Would request a second opinion.

[bdach]

I mean the last time this was attempted (#11887), it tried to not do anything to the inheritance, but because ModNightcore : ModDoubleTime, adding a toggle to ModDoubleTime would add a toggle to ModNightcore, which wasn't wanted, which was attempted to be papered over by making the bindable virtual and overriding it to be disabled in ModNightcore, which in turn caused issues with bindable disable not working all that well and as such introduced a dependency on a beached framework PR.

So I dunno how else you'd do this at this point. It's a mess.

[peppy]

Wondering if some of the logic can be split out into a helper method / class to reduce the code share..

[Givikap120]

Wondering if some of the logic can be split out into a helper method / class to reduce the code share..

i think of changing old DT into like DT_Raw, putting all logic here
and then actual DT only will implement the pitch switch
same with HT
this will reduce the code share, but kinda overengineers a little

[peppy]

I've tidied things up using a helper class with composition structure.

@bdach please double-check this.

[bdach]

I pushed some inline comments (cff69d6) because I was initially confused why Mod{Day,Night}core had the helper but were only using it for the multiplier. Looks good otherwise as far as I can tell.

[exformation]

Isn't this inverted?

This sounds like chipmunks singing, but the opposite should be true.

If you only increase the playback rate of a song, without adjusting pitch, the pitch scales and sounds wacky. If you "adjust for pitch", the pitch should sound the same as 1x.

[frenzibyte]

When turning on the Adjust pitch setting, the pitch of the track changes alongside the tempo. The way you're describing how the setting works sounds backwards to expectation. If you want to discuss this further, open a Q&A discussion thread.