Add two spins gap before awarding bonus score on osu! spinners #24662
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a player could gain two extra bonus ticks on any spinner in any map compared to stable. For balancing sake, this PR mimics stable behaviour and adds a gap of two spins before awarding bonus score.
In addition, spinners with certain durations / mods combination on stable have a 1.5x spinner gap instead of 2x, which can't be easily achieved here as it involves changing everything to work in "half spins" unit instead. Therefore, for simplicity, all spinners in lazer have a two-spins gap, regardless of their duration or the mods applied.
Tested on https://osu.ppy.sh/beatmapsets/1226922#osu/2551375; On master, a spinner reaches completion state after 11 spins, and bonus is awarded afterwards. Meanwhile, on this PR and in stable, a spinner reaches completion state after 9 spins, and the player keeps getting tick score for two extra spins, then starts getting bonus scores afterwards.