Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OAuth refresh attempt when no network available causing full logout (part 2) #25029

Merged
merged 1 commit into from
Oct 6, 2023

Commits on Oct 6, 2023

  1. Fix OAuth refresh attempt when no network available causing full logo…

    …ut (part 2)
    
    This time for `SocketException`s. I seem to recall looking at this and
    deciding there was a reason to not catch socket exceptions, but on
    revisiting it seems sane to do so.
    
    This covers a fail case like reported:
    
    ```
    2023-10-06 03:24:17 [verbose]: Request to https://lazer.ppy.sh/oauth/token failed with System.Net.Http.HttpRequestException: No such host is known. (lazer.ppy.sh:443)
    2023-10-06 03:24:17 [verbose]: ---> System.Net.Sockets.SocketException (11001): No such host is known.
    2023-10-06 03:24:17 [verbose]: at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
    ```
    
    Closes ppy#24890 (again).
    peppy committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    c78b511 View commit details
    Browse the repository at this point in the history