Fix multiplayer not correctly pausing the track on initialisation #25079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner` This call is responsible for ensuring the clock is in a stopped state.
….Stop` The reasoning is explained in the inline comment, but basically this was getting blocked by `isPaused` being in an initial `true` state (as it is on construction), while the source clock was still `IsRunning`. There's no real guarantee of sync between the source and the `isPaused` bindable right now. Maybe there should be in the future, but to restore sanity, let's ensure that a call to `Reset` can at least stop the track as we expect.
|
My main - and rhetorical - question here is how did any of multiplayer work given these omissions? I'm not gonna spend time digging into the answer to that. The fixes look good and generally harmless. I'll take this as a sign that the clock stuff is progressing in the correct direction in general. |
bdach
reviewed
Oct 10, 2023
|
💀 good riddance |
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
bdach
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves crashes experience in the last release (before the hotfix):
https://sentry.ppy.sh/share/issue/34bf79ed73c043b58b09369f45835cd7/
https://sentry.ppy.sh/share/issue/8b4161417ef8438b984c6577b031195e/
https://sentry.ppy.sh/share/issue/506cd43cd7f646ea95ceb3a79eff6c33/
The title says this only affects multiplayer, but it also does have a small chance of affecting solo play (resolved by f0bd975).
Please see individual commit messages for further notes.
Closes #25048.