Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiplayer not correctly pausing the track on initialisation #25079

Merged
merged 5 commits into from
Oct 10, 2023
Merged

Fix multiplayer not correctly pausing the track on initialisation #25079

merged 5 commits into from
Oct 10, 2023

Commits on Oct 10, 2023

  1. Add failing test coverage of player not pausing track correctly

    @peppy
    peppy committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    4319b22 View commit details
    Browse the repository at this point in the history

  2. Reduce severity of clock running check to avoid production crashes

    @peppy
    peppy committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    eee7dc0 View commit details
    Browse the repository at this point in the history

  3. Fix MultiplayerPlayer never calling Reset on `GameplayClockContai… 

    …ner`

This call is responsible for ensuring the clock is in a stopped state.
    @peppy
    peppy committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    100c0cf View commit details
    Browse the repository at this point in the history

  4. Change GameplayClockContainer.Reset to directly call `GameplayClock… 

    ….Stop`

The reasoning is explained in the inline comment, but basically this was
getting blocked by `isPaused` being in an initial `true` state (as it is
on construction), while the source clock was still `IsRunning`.

There's no real guarantee of sync between the source and the `isPaused`
bindable right now. Maybe there should be in the future, but to restore
sanity, let's ensure that a call to `Reset` can at least stop the track
as we expect.
    @peppy
    peppy committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    f0bd975 View commit details
    Browse the repository at this point in the history

  5. Adjust comment to match current behaviour 

    Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
    @peppy @bdach
    peppy and bdach committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    b9dadc5 View commit details
    Browse the repository at this point in the history