Apply various fixes and cleanup to spinner logic #25143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Happens when the first update frame comes in before any mouse input.
Should have been removed as part of ppy#24360.
smoogipoo
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes a good portion of #24999 which can be immediately merged and adds a bit of clean-up on top.
Of note, the majority of this is @smoogipoo's work. I'll add notes for the changes I've made on top:
0bb95cf Fix incorrect initial rotation transfer value
Should have been removed as part of #24360. As discussed on discord
10bab61 Tidy up
lastAngleusage and add assertion of maximum deltaAs a precursor to an attempt at refactoring the
SpinnerSpinHistorychange, I want to assert the maximum input delta to the equation. I also found thatlastAnglewas being updated in the normalisation logic when it didn't need to be.04af46b Change
SpinFramesGeneratorto take degrees as inputWe use angles in most other places so this feels more natural to work with.
I've also added
Ignorerules to some tests which are still valuable for working forward, but will fail on the current implementation of spinner rotation handling.