Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply various fixes and cleanup to spinner logic #25143

Merged
merged 9 commits into from
Oct 16, 2023
Merged

Apply various fixes and cleanup to spinner logic #25143

merged 9 commits into from
Oct 16, 2023

Commits on Oct 16, 2023

  1. Fix large instantaneous delta on first frame 

    Happens when the first update frame comes in before any mouse input.
    @smoogipoo @peppy
    smoogipoo authored and peppy committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    84be714 View commit details
    Browse the repository at this point in the history

  2. Rename RateAdjustedRotation to TotalRotation

    @peppy
    peppy committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    159b24a View commit details
    Browse the repository at this point in the history

  3. Add SpinFramesGenerator class to simplify creating spinner tests

    @peppy
    peppy committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    cfa4adb View commit details
    Browse the repository at this point in the history

  4. Add prospective test coverage of spinner input handling

    @peppy
    peppy committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    28ee99f View commit details
    Browse the repository at this point in the history

  5. Change SpinFramesGenerator to take degrees as input

    @peppy
    peppy committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    04af46b View commit details
    Browse the repository at this point in the history

  6. Tidy up lastAngle usage and add assertion of maximum delta

    @peppy
    peppy committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    10bab61 View commit details
    Browse the repository at this point in the history

  7. Fix incorrect initial rotation transfer value 

    Should have been removed as part of ppy#24360.
    @peppy
    peppy committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    0bb95cf View commit details
    Browse the repository at this point in the history

  8. Fix potential frame misordering in generator

    @smoogipoo
    smoogipoo committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    3065c9f View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into split-spinner-fix

    @bdach
    bdach committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    f14928c View commit details
    Browse the repository at this point in the history