Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to revert slider settings to default when double-clicking nub #25163

Merged
merged 2 commits into from Oct 18, 2023

Conversation

Joehuu
Copy link
Member

@Joehuu Joehuu commented Oct 18, 2023

Just a change I had hanging. Didn't do it in framework because it needs a nub to work (framework only implements the nub locally in a test).

Kapture 2023-10-17 at 21 58 18

Copy link
Sponsor Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems simple enough, works well.

If anything is going to fail with this, it's likely going to require changes to framework double-click handling (we don't use this in many places yet). Let's see.

@peppy peppy merged commit bf4aa3c into ppy:master Oct 18, 2023
15 of 17 checks passed
@Joehuu Joehuu deleted the double-click-slider-nub-default branch October 18, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants