Fix some touch device-related issues #25432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly matters for web, so that it doesn't permit creation of playlist items with touch device inside.
It should not run in multiplayer. Even if we wanted to allow touch-only playlist items at some point, the current behaviour of multiplayer song selects with respect to touch device mod is currently just broken.
peppy
approved these changes
Nov 14, 2023
xdi1
added a commit
to xdi1/osu
that referenced
this pull request
Nov 17, 2023
commit dee6a799113fe24f5acab7088c5d0e0c305adad3
Merge: 87a76b9ee8 b88e3cd26f
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 16 22:25:14 2023 +0900
Merge pull request #25481 from peppy/make-skin-store-fallback
Change `ResourceStore` provided to `Skin` to be a fallback, not replacement
commit b88e3cd26f8eb3f7b90e8bc6a96097ae23d3773e
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 16 20:16:23 2023 +0900
Change `ResourceStore` provided to `Skin` to be a fallback, not replacement
commit 87a76b9ee80055a85cb51a12e0a70083c1ba63e2
Merge: 0a8ede6274 dc2d574965
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 16 17:39:35 2023 +0900
Merge pull request #25478 from Joehuu/fix-comment-markdown
Fix `CommentMarkdownTextFlowContainer` not inheriting osu! class
commit 0a8ede627465586c54ad324eb140a268f77da353
Merge: d09d58639a b45872d2e0
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 16 17:01:03 2023 +0900
Merge pull request #25469 from Joehuu/argon-hide-counter-labels
Add ability to toggle labels on argon counter components
commit d09d58639ae0cd07bf472d05b32aaee50827e81a
Merge: 4642b916b0 1e2f1b3ef2
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 16 16:47:03 2023 +0900
Merge pull request #25400 from frenzibyte/unload-main-menu-storyboard
Unload beatmap storyboards when not in main menu screen
commit 1e2f1b3ef202d3a7f80274f1c87725e41287c5c2
Merge: dbd4f26436 4642b916b0
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 16 15:46:44 2023 +0900
Merge branch 'master' into unload-main-menu-storyboard
commit dbd4f26436c988a8d1e1afb6e893e82fedb25460
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 16 15:37:53 2023 +0900
Use alternative method of scheduling storyboard unload
commit b45872d2e0f901e65c6e44cc0439f29b562f3785
Merge: 73eda6c09c 4642b916b0
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 16 14:20:13 2023 +0900
Merge branch 'master' into argon-hide-counter-labels
commit 73eda6c09c259e0f517ffa75a0affb8902ef1fd4
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 16 14:18:49 2023 +0900
Move non-matching default value to argon skin default speficiation instead
commit 39a3313929035bc50e308a5ecee8f568f85dbe76
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 16 14:11:01 2023 +0900
Update tooltip description slightly
commit 4642b916b0b0b2a212a5b72edfc78036d3a3628f
Merge: 7f90db7603 0c0093e641
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 16 13:44:39 2023 +0900
Merge pull request #25468 from peppy/argon-skin-coverage
Add test coverage of accessing skin layout after importing customised default skins
commit dc2d5749651de89bd1e4d5bba615068bfce1ac30
Author: Joseph Madamba <madamba.joehu@outlook.com>
Date: Wed Nov 15 19:41:13 2023 -0800
Fix comment markdown image not showing tooltips
commit 2b19cf6ce4b908880db4854a4f74d30edd7714ac
Author: Joseph Madamba <madamba.joehu@outlook.com>
Date: Wed Nov 15 19:43:25 2023 -0800
Fix comment markdown style regression
commit 7f90db7603714c665ae05cd83f59c61060d8dd2f
Merge: 189fca2eb6 2987c0e802
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 15 19:02:30 2023 +0900
Merge pull request #25472 from bdach/argon-health-folding-in-on-self
Fix argon health bar folding in on itself when too narrow
commit 2987c0e802ec597ab7480c9d3623b423592669bc
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 15 19:01:52 2023 +0900
Add note about enfocing size methodology
commit 0c0093e6413300efa4d3c41e173a0f8f73723a7e
Merge: b118999120 189fca2eb6
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Wed Nov 15 18:30:03 2023 +0900
Merge branch 'master' into argon-skin-coverage
commit b118999120ec13d4632f032429fbc3a26cc43db2
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Wed Nov 15 18:27:08 2023 +0900
Remove unused using directive
commit 189fca2eb6b6327e9efc5074aa0304af940546f9
Merge: 10be233562 7b987266d5
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 15 18:01:24 2023 +0900
Merge pull request #25339 from joshika39/change-clickable-avatars-tooltip-for-usergrid
Add `UserGridPanel` as the `ClickableAvatar` tooltip
commit 7b987266d50db8b3c5668a27625f7635a6eeefbc
Author: Joseph Madamba <madamba.joehu@outlook.com>
Date: Tue Nov 14 16:15:22 2023 -0800
Change behavior of some clickable avatars in line with web
commit deef8998f73850d0e40247fa5854f042967e4687
Author: Joshua Hegedus <josh.hegedus@outlook.com>
Date: Fri Nov 10 11:45:31 2023 +0100
reverted the change
commit aa9deecafe7ad9150d82bfa7015d7e21cf3888b5
Author: Joshua Hegedus <josh.hegedus@outlook.com>
Date: Fri Nov 10 11:37:23 2023 +0100
added missing comment, fixed incorrect visibility
commit 8cd1f08a923b1b38e7b096e59211c0714089d1e5
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Wed Nov 15 13:33:12 2023 +0900
Fix argon health bar folding in on itself
commit aac1854d832ff8ad48333ed0afd968ab50dcf712
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 15 14:08:05 2023 +0900
Add test coverage of layout retrievable after importing modified skins
commit a5e1dd8107a8770ab8698cc39a17df2e81847a8b
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 15 14:07:51 2023 +0900
Add test coverage of deserialising a modified Argon skin
commit 62352ce5f3b6ce56c310a83dccd11d9eb15f90fa
Author: Joseph Madamba <madamba.joehu@outlook.com>
Date: Tue Nov 14 20:45:23 2023 -0800
Add ability to toggle labels on argon counter components
commit 87ace7565dfffebbcfb34f48743406a0c68d1065
Author: Joseph Madamba <madamba.joehu@outlook.com>
Date: Tue Nov 14 20:44:33 2023 -0800
Use existing localisation for argon counter component labels
commit 71714f8f6e6bd7d2caf9214ff267c05e550352e7
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Wed Nov 15 13:33:03 2023 +0900
Add back test step for testing out argon health bar width
commit 10be2335621657391be8e2b7a5395738f61f65b6
Merge: 3b619d4c34 159cf41f82
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 15 13:30:36 2023 +0900
Merge pull request #25466 from bdach/argon-health-initial-width
Fix default argon health bar width being zero
commit 159cf41f824546013c22ec454fe1bb33a460f2d1
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Wed Nov 15 12:24:47 2023 +0900
Fix default argon health bar width being zero
Closes #25460.
commit 3b619d4c34ef362344f5dd5ab83dba7fece2e604
Merge: 711bf14c06 2264e1e249
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 15 11:10:59 2023 +0900
Merge pull request #25458 from Joehuu/corner-radius-localisation
commit 2264e1e2493b69d0455f57639e60e3e2e10f7e96
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 15 10:45:01 2023 +0900
Change default value and range of `BoxElement`'s corner radius to match other usages
commit 74fb1b5f81475121af75072367759a241aa4db38
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 15 10:40:59 2023 +0900
Rename property to match expctations
commit 535282ba7d90303058c429c564c9d473afaf8e99
Author: Joseph Madamba <madamba.joehu@outlook.com>
Date: Tue Nov 14 14:13:20 2023 -0800
Use existing localisation for corner radius in `BoxElement`
commit 711bf14c069a7a060d48ea08ec5d58397caa17bc
Merge: 6e0375e3e8 9a7d7dda2a
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Tue Nov 14 23:11:39 2023 +0900
Merge pull request #25443 from peppy/fix-argon-custom-skins
Fix customised argon skins no longer loading due to incorrect resource store specification
commit 6e0375e3e8d2177c6acaf62e6a1973af2be10cc7
Merge: 572ec918d6 83f8f03c7e
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 14 23:10:03 2023 +0900
Merge pull request #25442 from bdach/argon-health-bar-sizing-broken
Fix argon health bar not relative sizing correctly
commit 9a7d7dda2ae564fef11f3e544be339da42abb8d8
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 14 23:04:11 2023 +0900
Update resources
commit a745642f764cf28b37800936186399f459cdd47d
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 14 22:01:56 2023 +0900
Fix customised argon skins no longer loading due to incorrect resource store spec
commit 83f8f03c7e3b173766e9c715bd7869929082600b
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Tue Nov 14 21:46:57 2023 +0900
Fix argon health bar not relative sizing correctly
commit 572ec918d678183b2845bf3f00197e0bc84e31dc
Merge: bb2f38d189 70d2de5669
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 14 17:18:38 2023 +0900
Merge pull request #25432 from bdach/touch-device-fixes
Fix some touch device-related issues
commit 70d2de56695800a2ca14a027d32cf2c36153e8f5
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Tue Nov 14 16:35:16 2023 +0900
Move song select touch detector to solo implementation
It should not run in multiplayer. Even if we wanted to allow touch-only
playlist items at some point, the current behaviour of multiplayer song
selects with respect to touch device mod is currently just broken.
commit 69c2c0e4278d4d419b3ee1ea11f4c8e491514247
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Tue Nov 14 16:30:08 2023 +0900
Fix touch device mod declared valid for multiplayer
Mostly matters for web, so that it doesn't permit creation of playlist
items with touch device inside.
commit bb2f38d189b4a1a6ff888f5a74caf90ec60bf746
Merge: 469b9e2546 7d26de723a
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sun Nov 12 20:47:55 2023 +0900
Merge pull request #25411 from peppy/fix-key-counter-sizing-woes
Refactor `KeyCounterDisplay` to use autosize
commit 469b9e2546a0eea247f19bdc9e793170fe7c7b05
Author: Dean Herbert <pe@ppy.sh>
Date: Sun Nov 12 17:28:15 2023 +0900
Increase size and adjust positioning of max combo display in argon skin
commit 7d26de723a789b14f76fbb18b6b4be4b6a7aba93
Merge: 798e677c09 31feeb5ddc
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sun Nov 12 17:23:31 2023 +0900
Merge branch 'master' into fix-key-counter-sizing-woes
commit 31feeb5ddc616bb437c052b2b1680070c9d72563
Author: Dean Herbert <pe@ppy.sh>
Date: Sun Nov 12 17:21:17 2023 +0900
Disable new rider EAP inspection in test class
commit 798e677c092a4ad02e0fe0a81163c14b57ff90d4
Author: Dean Herbert <pe@ppy.sh>
Date: Sun Nov 12 15:12:04 2023 +0900
Refactor `KeyCounterDisplay` to use autosize
A previous attempt at this was unsuccessful due to a partially
off-screen elements not getting the correct size early enough (see
https://github.com/ppy/osu/issues/14793). This can be accounted for by
setting `AlwaysPresent` when visibility is expected.
This fixes [test failures](https://github.com/ppy/osu/actions/runs/6838444698/job/18595535795)
due to the newly added `Width` / `Height` being persisted with
floating-point errors (by not persisting the values in the first place,
via `AutoSize.Both`).
commit b995c96dca4e1163edaa8c67fe878425f6b91399
Merge: ccfdf1ffd6 3e8c89e282
Author: Dean Herbert <pe@ppy.sh>
Date: Sun Nov 12 12:14:26 2023 +0900
Merge pull request #25226 from frenzibyte/gameplay-hud-redesign/counters
commit 3e8c89e282c74874a8c6885228910d70b64d2e95
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sun Nov 12 07:42:41 2023 +0900
Fix one more reference to removed setting
commit c3201d59449a6b281bcbf904871c526dc8873141
Merge: 04a16b3596 ccfdf1ffd6
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sun Nov 12 07:33:50 2023 +0900
Merge branch 'master' into gameplay-hud-redesign/counters
commit ccfdf1ffd6b34aafa91cfce634b63d8fe8556267
Merge: c5bbd5ac8a 50789d2e18
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sun Nov 12 07:31:51 2023 +0900
Merge pull request #25402 from peppy/skin-size-editing
Add support for adjusting size of skin elements
commit 04a16b35966daf6a0ce3a42096be7857f2ec15f2
Merge: ea556abad8 c5bbd5ac8a
Author: Dean Herbert <pe@ppy.sh>
Date: Sat Nov 11 22:38:39 2023 +0900
Merge branch 'master' into gameplay-hud-redesign/counters
commit c5bbd5ac8a7cac4d7fbf2650d54992acdd8cd8e6
Merge: ed59a379f1 b0aa4a4257
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sat Nov 11 21:48:21 2023 +0900
Merge pull request #25408 from peppy/skin-editor-export
Add "export" item to skin editor menu
commit ea556abad802b4cb36ee7ad42b2b7c66b6029f56
Merge: 870e4ce27e 50789d2e18
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sat Nov 11 21:28:29 2023 +0900
Merge branch 'skin-size-editing' into gameplay-hud-redesign/counters
commit 50789d2e18a43dd3b2a2e99ea9487851972f35f9
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sat Nov 11 21:28:04 2023 +0900
Fix song progress bars not sizing vertically properly
commit ee56b4d205f916ea9cf45543c72cce34f53b8a7e
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sat Nov 11 20:55:47 2023 +0900
Use barely better assertion fail message in test
commit 870e4ce27e751d2a7129d5fe396f2f96e74865bc
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sat Nov 11 20:42:45 2023 +0900
Fix argon health display not handling invalidation correctly
commit b0aa4a4257a5f590a1b65613cbf988b7034d7a9e
Author: Dean Herbert <pe@ppy.sh>
Date: Sat Nov 11 20:34:35 2023 +0900
Add "export" item to skin editor menu
commit b7972e3c8485b8a9b3ee4df20bd62b2ed59613a3
Merge: a02aeed50a 8d7539ab70
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sat Nov 11 20:15:49 2023 +0900
Merge branch 'skin-size-editing' into gameplay-hud-redesign/counters
commit ed59a379f16eb093a866422b36e2a80d9200bbfc
Merge: 4b3fd1716a 61d336521d
Author: Dean Herbert <pe@ppy.sh>
Date: Sat Nov 11 20:15:07 2023 +0900
Merge pull request #25407 from peppy/update-framework
Update framework
commit 8d7539ab70ab1a3cece963afa36802ddd7518682
Merge: b247b94ecb 4b3fd1716a
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sat Nov 11 19:56:09 2023 +0900
Merge branch 'master' into skin-size-editing
commit 4b3fd1716a4850ce54b31fdc87a81cc80f26f149
Merge: 1c63f1f89d 2428a97d44
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sat Nov 11 19:55:04 2023 +0900
Merge pull request #25406 from bdach/skin-editor-bad
Fix skin editor not clearing undo history on skin change
commit 61d336521da4adc3c8dcc6bacc20a7f23a306d34
Author: Dean Herbert <pe@ppy.sh>
Date: Sat Nov 11 19:48:56 2023 +0900
Update framework
commit b247b94ecbdb5405de16ba489ef7a62b36cd7656
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sat Nov 11 19:15:20 2023 +0900
Revert test changes
They were broken because `SerialisedDrawableInfo` is a reference type
and as such equality checks will use reference equality rather than
member equality.
commit 2428a97d449b5e5f51ea2f9c8805c32521301a07
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sat Nov 11 17:02:21 2023 +0900
Fix editor not clearing undo history on skin change
commit 21e1d68b15960c448d9876baaec51776febde22c
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sat Nov 11 15:52:24 2023 +0900
Remove unused using directive
commit 96da7a07bbd79bc67cbc58196bb38cd6c835c83a
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Sat Nov 11 02:57:29 2023 +0300
Add detailed explaination on existence of `ScheduleUntilTransitionEnd`
commit bb912bc6161a8785f105e3da29f7e95f83261249
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Sat Nov 11 02:57:17 2023 +0300
Avoid spinning another load thread on initial storyboard load
commit 080f13e34d0f5f60381d813edfd590aa2b466194
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Sat Nov 11 02:56:16 2023 +0300
Schedule outside of `UnloadStoryboard` and fix disposal happening on update thread
commit 2e48569982039c9c1e6cb722190a6669ea09aee7
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 20:00:51 2023 +0900
Improve test comparison logic
Doesn't really help that much with nunit output,
but at least you can breakpoint and see the json kinda.
commit 57cd5194ce06b16e03dc0dea32a0e81da80b1029
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 20:00:20 2023 +0900
Flip comparison to allow non-composite drawables to still get resized
commit b7acbde719744a3aac166c676b792e9d87699612
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 19:12:26 2023 +0900
Only store width/height of serialised drawable if it isn't automatically computed
commit b6dcd7d55f0d421d85e2e97d00ae5704d1fb5487
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 18:48:45 2023 +0900
Fix tests so that they actually assert something
commit fbf94214a536a5b5aa7246d2ee34ee5ecacf8fb1
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 18:36:09 2023 +0900
Fully delegate tooltip show/hide logic
commit ec2200d54fff1cf823355571c2a3c827c3a19ca8
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 18:26:08 2023 +0900
Remove another reference to bar length
commit 26eae0bdeeed6670fc3a47b81abdc75afceda434
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 18:25:39 2023 +0900
Remove unused using directive
commit 43a4b34295471a2a4c0103aa9383ef75cbb8dc56
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 18:20:14 2023 +0900
Fix typo
commit c522a703eb4c7122863867124ac309a77b950dd0
Merge: 374e13b496 1c63f1f89d
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 18:19:27 2023 +0900
Merge branch 'master' into skin-size-editing
commit 374e13b496dc3780e03f2c9f76a850ab0a8050e5
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 18:18:45 2023 +0900
Remove argon health display bar length setting
It is no longer needed.
Intentionally not doing backwards migration to simplify things; users
can fix their skins.
commit 2c1f304f3b4faaa645edb3c138b915ad351c9fa0
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 18:13:36 2023 +0900
Fix test failures due to fluctuations in needlessly-serialised automatic sizings
commit 1c63f1f89dadef715138cf3979c17110db3fb9bf
Merge: 74ccb0873e b7938e78a0
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 18:01:40 2023 +0900
Merge pull request #25348 from bdach/less-basic-touchscreen-detection
Implement basic touchscreen detection
commit 36d0bae42dfe95481b3e20751d8f7032b925e9df
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 17:57:16 2023 +0900
Restore mention of dependency on another ctor param
commit 35e11c7c63b83122a45f5f9820aa6909ffb892bd
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 17:51:30 2023 +0900
Rename diagonal scale variable and update xmldoc
commit d0f1326a63da2187c80c7429cf386bfb3856c8c5
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 17:54:48 2023 +0900
Fix formatting
commit f25489cc7be71426891f50046b70aefdc24578de
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 17:53:56 2023 +0900
Check X/Y sizing available separately to fix weird edge cases
commit 46a219e01010e32827f3772aae77fece7de8bccf
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 17:53:02 2023 +0900
Add comment explaining `AutoSize` change in `LegacySongProgress`
commit 74ccb0873edcbaa7af5a26973c30bc17e9ec3cf0
Merge: 7c4e9506da 93ff82bc80
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 16:59:17 2023 +0900
Merge pull request #25403 from smoogipoo/attempt-fix-diffcalc-quotes
Attempt to support quotes in handling of GH comment body
commit a02aeed50af48f580a1c5d7fbb8a792f2a652f1a
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 16:50:41 2023 +0900
Adjust combo animation slightly
commit 67312a2db922287fef12c53f00be99b2aa79df8d
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 16:43:47 2023 +0900
Remove `ArgonScoreWedge` and use `ArgonWedgePiece` directly
commit b4ec62473e0e79638b439a9ffd677871014841b3
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 16:37:07 2023 +0900
Remove width/height bindables from `ArgonWedgePiece`
commit fa5921862f99e6ed4a9757938ad77a8bd9d066ed
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 16:19:42 2023 +0900
Update deserialising test
commit b7938e78a0dc05f6847323058ef58f235e67324f
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 16:30:21 2023 +0900
Make sure test is in a break
...because apparently it may take a while to update the flag.
commit 7c4e9506dad02f7e4282ac478f765d844e954654
Merge: a8cf105beb 1b08f317fb
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 16:25:01 2023 +0900
Merge pull request #25399 from Susko3/mobile-touch-settings
Show touch input settings on mobile
commit 7db14baed74277383e4ac567577bb08b3b2aeea5
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 16:13:45 2023 +0900
Update resources
commit 60df2722ab7d72e040b176d0d756493c6c2daf4e
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 16:04:28 2023 +0900
Rename `RoundedLine` to `BoxElement` and make more generically useful
commit 8690b0876928570e5df1d25a1568db6ec703ee05
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 16:08:45 2023 +0900
Fix compose select box test failures
commit 1818a84034c57f76335e06371b6a68296b0126f4
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 15:52:02 2023 +0900
Rewrite tests to not rely on realtime clock
Definitely faster, hopefully more reliable too.
commit 4f90ac15fad7df54047abd01b6f88b6e28310277
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 15:39:17 2023 +0900
Reduce the default wireframe opacity a bit
commit 7e0b41219cd916931bd18d32f87705624b4e723b
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 15:26:37 2023 +0900
Change animation to only affect number portion, add miss animation
commit e861681cd4a081b3cc557df725cb0d2737096ebc
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 15:06:19 2023 +0900
Adjust argon rolling easings
commit 7c3a626f4b2a1706cfc46295770b8673b374aee4
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 15:06:07 2023 +0900
Add basic animation for combo counter
commit 6c1d48dfaf0e4f06489b22c32b437a2d18d5250a
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 14:51:14 2023 +0900
Remove unused function
commit 99d9db5b76ba5292398201039e75fcb0a9bcc1d7
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 14:03:24 2023 +0900
Use a better default size for line
commit f31c1c9c7941db573a9516710e42e53946947e25
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 12:58:07 2023 +0900
Rename and move skinnable line component to a more commomn place
commit a8cf105beb7d8f746c4df2957d448dabc86044d2
Merge: 1a8636638d 44c0442f4f
Author: Dan Balasescu <smoogipoo@smgi.me>
Date: Fri Nov 10 15:07:05 2023 +0900
Merge pull request #25342 from peppy/slider-combo-matching-2
Fix osu! (slider) combo not matching expectations when classic mod is disabled
commit 93ff82bc80c8bc06bc78149fd49584396ca982bd
Author: Dan Balasescu <smoogipoo@smgi.me>
Date: Fri Nov 10 14:52:03 2023 +0900
Attempt to support quotes in handling of GH comment body
commit 175dae49c623bfa8632608e204cac168d0b9723a
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 14:43:51 2023 +0900
Reset scale per axis
commit 0add035c674d59bd36ef129d474a76550e3ced92
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 14:31:02 2023 +0900
Disable resizing of `LegacySongProgress`
Because it looks bad.
commit fb361a4e0a8152bb35fe16cdc98bf06993f64a67
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 14:25:55 2023 +0900
Reset size along with scale for relative items
commit ec3b6e47fb7c6b302e633132362bfe54873a58a6
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 14:17:11 2023 +0900
Change selection handling to adjust `Size` instead of `Scale` for edge nodes
commit b0c5b3cb1097861506b11862b996b91afe7a384a
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 14:15:42 2023 +0900
Add `Size` to serialised components of a `SerialisedDrawableInfo`
commit 44c0442f4fc7f29f94ea1acad609ab8a676788d0
Author: Dan Balasescu <smoogipoo@smgi.me>
Date: Fri Nov 10 14:00:34 2023 +0900
Adjust comment on Slider's judgement
commit 1a8636638dd8a7e8a7f9584aa5fa483e21305981
Merge: 8d47c64325 12a148d108
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 05:01:21 2023 +0100
Merge pull request #25385 from peppy/update-squirrel
Update squirrel to latest release
commit f13648418b82f7158a733588e8caf4f094efc1ec
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 12:10:52 2023 +0900
Update `HitResultTest` to be more conformant to original expectations
commit fb02c317507b7c58770bdd52984eb6a0f91f9b53
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 12:09:48 2023 +0900
Fix typo in assert step
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
commit e0a5ec5352d0edf5d73513e203cdeda51624a302
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 12:09:16 2023 +0900
Revert incorrect classic mod test assertions
commit 7fc2050f7227424b7e734260126146c48e99358e
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 11:52:34 2023 +0900
Rename variables and mak seconary tooltip type work again
commit d3af3c615f01fafb22dc4d0dbeeeb417c73a72c0
Merge: 6f5d905ce7 8d47c64325
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Fri Nov 10 01:04:03 2023 +0300
Merge branch 'master' into gameplay-hud-redesign/counters
commit 6f5d905ce766da9b2e3753585a41298118e9c6b9
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Fri Nov 10 00:34:29 2023 +0300
Update argon accuracy counter design
commit 59998b507acf084cc8d4ffbe85e16d1f3fab9229
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Thu Nov 9 23:23:49 2023 +0300
Hide background sprite when storyboard finishes loading
commit e9471589697083d8ea2214b299aca226085e7de9
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Thu Nov 9 23:03:01 2023 +0300
Remove fade out transition
Unnecessary addition from this PR, makes the background fade to ugly black during transition between screens.
commit cc9aeb53079f6f00af307fb0544e0335d9eebcc8
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Thu Nov 9 22:57:12 2023 +0300
Add test coverage
commit 768a31b2f5ec05907f2e1cf18d4bb3f63ae83da1
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Thu Nov 9 22:56:48 2023 +0300
Fix background crash on a beatmap with no storyboard
commit bd8409219f079bcdd922ae2169d676608e512364
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Wed Nov 8 06:37:29 2023 +0300
Unload beatmap storyboard background when no longer present
commit d4722a398892a18f14e868ff471e9132004da8fd
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Thu Nov 9 17:20:05 2023 +0300
Add failing test case
commit 1b08f317fbd1fac55276dc05c29b0339667f2871
Author: Susko3 <Susko3@protonmail.com>
Date: Thu Nov 9 15:12:24 2023 +0100
Show touch input settings on iOS
This does not cover android since `TouchHandler` is SDL-based.
commit 0c4c9aa4b515840611b3b39017ff73d04a3ecf1b
Author: Susko3 <Susko3@protonmail.com>
Date: Thu Nov 9 14:37:10 2023 +0100
Show touch taps setting in player loader on mobile platforms
commit 51cf85a9ab3806fe9294d33b24c52165a08aed6b
Author: Susko3 <Susko3@protonmail.com>
Date: Thu Nov 9 13:22:49 2023 +0100
Add touch input settings to android
Also updates touch settings so the touch handler can't be disabled on mobile.
commit 8d47c64325ead06322d13cbeee82c46b23b262e8
Merge: 5180fa669b 4fa158e0d8
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 9 14:39:01 2023 +0100
Merge pull request #25398 from peppy/tournament-split-players-better
Split tournament player lists more equally
commit 615d8384abcc3c412a831a70a73ed0f6c6173467
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 9 22:27:29 2023 +0900
Refactor everythign back to sanity
commit edef31f426f8568afc3abf53b7611e525308c1d0
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 9 21:48:41 2023 +0900
Correctly propagate classic behaviour flag to tail
commit 1ae3265f925911c3a1f7f640805765b68dc5d335
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 9 21:24:30 2023 +0900
Update tests in line with new behaviour
commit 4fa158e0d832f44cddefac1b0dd7b94f879e3993
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 9 21:35:37 2023 +0900
Split tournament player lists more equally
commit 5180fa669ba55a5d22c6aca197ee5b315437acb7
Merge: 67dc3aa5b7 92e4a8666d
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 9 13:34:29 2023 +0100
Merge pull request #25343 from peppy/spinner-max-sample
Continue to play spinner bonus sounds when MAX display occurs
commit 4900a91c60fda24f76aeba4d2d2bf42cc1929e2d
Author: Joshua Hegedus <josh.hegedus@outlook.com>
Date: Thu Nov 9 13:27:09 2023 +0100
fixed static analysis problems and finished the implementation
commit ccb9ff826a87dbafbbeb0a0a572a404bc88c7e88
Author: Joshua Hegedus <josh.hegedus@outlook.com>
Date: Thu Nov 9 13:09:59 2023 +0100
fixed tests
commit 92043f45a47b89a22695089d93aeb87c12553c58
Merge: d3c5988bf1 67dc3aa5b7
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 9 18:45:37 2023 +0900
Merge branch 'master' into slider-combo-matching-2
commit 02966bc02f61c776dc7333c7d0531338c7716927
Merge: f897c21b3f 67dc3aa5b7
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 9 18:19:23 2023 +0900
Merge branch 'master' into change-clickable-avatars-tooltip-for-usergrid
commit 67dc3aa5b7efa4a722c9d51a7da7e16ceaed6d54
Merge: 67de1b34bd c00a1d948a
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 9 18:19:02 2023 +0900
Merge pull request #25366 from Susko3/better-touch-settings
Add "disable taps during gameplay" to touch input settings and related UI
commit 67de1b34bd2ea9ec8c199e1adfbff16094aeacb4
Merge: 5ac285ed2f e3e752b912
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 9 18:03:47 2023 +0900
Merge pull request #25395 from nekodex/buttonsystem-updates
SFX improvements for `ButtonSystem`/`MainMenu`
commit e3e752b912ba0b14f9d2d2a96bc1695e65eb94cd
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 9 17:56:58 2023 +0900
Update resources
commit 63a0ea54109c93984501b66435febf676663cab4
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 9 17:50:57 2023 +0900
Fix `PlayerTouchInputDetector` applying touch device mod when other inactive mods present
commit 5d5c803cf6fc97c044551a8bd7d3d11f0db8f41c
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 9 17:48:43 2023 +0900
Add failing test case for touch device application during gameplay with incompatible mods active
commit 13b599b9b64acb2fa5744e580f8df8d9fcff9fea
Merge: 39ad91feea 5ac285ed2f
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 9 17:36:48 2023 +0900
Merge branch 'master' into less-basic-touchscreen-detection
commit 8a47f05b1615e126c9841b52dd63576a5b1b521a
Author: Jamie Taylor <me@nekodex.net>
Date: Thu Nov 9 14:01:33 2023 +0900
Always play 'swoosh' sample when transitioning back to logo
commit 12a148d1084b1a6f11525ff16c223ecb6ddd6927
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 9 12:26:41 2023 +0900
Use new initialisation structure for github sourced update manager
commit f69c2ea39b46fff223c8372e6dd1d2a6b2da5bce
Author: Jamie Taylor <me@nekodex.net>
Date: Wed Nov 8 22:18:33 2023 +0900
Implement sample choking/muting for `ButtonSystem` samples
commit f0a1df06aced3051a93684588a6f21a0bf0fafd0
Author: Jamie Taylor <me@nekodex.net>
Date: Wed Nov 8 22:13:35 2023 +0900
Add 'swoosh' samples to accentuate `MainMenu` animations
commit 17aa079cb1cd1ee7ae22942aa582507c37037c4d
Author: Jamie Taylor <me@nekodex.net>
Date: Wed Nov 8 22:08:05 2023 +0900
Use new tiered 'back' samples
commit fc1a0cf645b345c1b2b0727313a4f11b207a3268
Author: Jamie Taylor <me@nekodex.net>
Date: Thu Oct 19 16:20:10 2023 +0900
Update `ButtonSystem` to use new sample names
commit 5ac285ed2f915bb828c9e0762ad5547cfe506e3f
Merge: 626cfae3fe 38d16f620c
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 8 18:56:00 2023 +0900
Merge pull request #25380 from frenzibyte/fix-create-difficulty-crash
Fix editor crash when creating a new difficulty in a non-existent beatmap
commit 626cfae3feb9dd70ab347b44f488c80a836681b4
Merge: 9df8fc14e7 38847c3ac5
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 8 17:24:37 2023 +0900
Merge pull request #25386 from EVAST9919/bar-graph-smooth
Ensure `BarGraph`'s draw quad is thick enough
commit 38847c3ac5383c9fb69b7bf0b38aa8ea36b23b39
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 8 17:23:01 2023 +0900
Change test to move only on a toggle step
commit 6c6baab1156f64388e5fcea3ad712cc7e24bb463
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 8 16:41:30 2023 +0900
Reword comment to explain why
commit 9df8fc14e708b6024ab66f9e9c1fc1afabf9451c
Merge: 34219c1103 c8d276281a
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 8 12:46:59 2023 +0900
Merge pull request #25388 from Joehuu/kudosu-rankings
Add ability to view kudosu rankings
commit c8d276281ada839a37ab6eb484c36b9b7772a0d1
Author: Joseph Madamba <madamba.joehu@outlook.com>
Date: Tue Nov 7 15:49:11 2023 -0800
Fix flags not showing on kudosu rankings
The `country` attribute is optional and not included in the kudosu rankings response so use `country_code` instead.
commit 387de7ec244f1e5c7381693b6dad96a64630ce1f
Author: Joseph Madamba <madamba.joehu@outlook.com>
Date: Tue Nov 7 15:53:41 2023 -0800
Add ability to view kudosu rankings
commit 2ef17c56b115c3df3d7a539f7494ad568b3a3ddf
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Wed Nov 8 02:13:35 2023 +0300
Remove unused local
commit d0fea381b18b5f19450f4d93951e0aed152a85c8
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Wed Nov 8 02:13:16 2023 +0300
Update skin deserialisation archives
commit 18c71c95ccc565255676140486f30a4ed6d3b04f
Merge: 07b7e13633 34219c1103
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Wed Nov 8 02:12:37 2023 +0300
Merge branch 'master' into gameplay-hud-redesign/counters
commit 07b7e13633862e85522f0c1778c8dc06ee62724d
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Wed Nov 8 02:07:24 2023 +0300
Place health display in front of the score wedge
commit 4de5454538b0dff1b8b4a020a7f12fcb294ccc06
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Wed Nov 8 02:06:51 2023 +0300
Bring back left-side line next to health display
Makes the score counter not look weird when it reaches 8 digits
commit fdc714a248d1a9283649d12a11a14e7763bfa1dc
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Wed Nov 8 02:05:19 2023 +0300
Support percentages and ignore dot characters in wireframes part
commit d30bac3f49af02f2473e9c1a71aacbdb8f42dd4e
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Wed Nov 8 01:49:13 2023 +0300
Move "required display digits" feature to reside in argon score counter
commit e6d3085353886da1a196f6d0354eae86ba9469fa
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Wed Nov 8 01:48:21 2023 +0300
Update accuracy counter design
commit cbea2db4bef9322b8dcbe9619d95cb918dcc3b55
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Tue Nov 7 02:03:16 2023 +0300
Support absolute-sized health bar and use it for default layout
commit b092b0093affc97453d4f14be7b7a68005d5ae31
Author: Andrei Zavatski <megaman9919@gmail.com>
Date: Mon Nov 6 21:13:36 2023 +0300
Make sure bar draw quad is thick enough
commit c00a1d948a94b871c4b50099d3f5924d142714c4
Merge: 3e257f1e6c 34219c1103
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 7 23:21:59 2023 +0900
Merge branch 'master' into better-touch-settings
commit 3e257f1e6c02795c6bbb6bf08f542707e8e6e827
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 7 23:21:51 2023 +0900
Remove unused using statements
commit 34219c11030239aa1674981c22ab397620b090a6
Merge: ed02335e3e 7bedf7cf16
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 7 21:57:00 2023 +0900
Merge pull request #25364 from frenzibyte/fix-resume-cursor-following-settings
Fix resume cursor following gameplay cursor scale setting
commit 02d9f005d09df3bd755a337a7d63c3ef4353d8b0
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 7 21:27:02 2023 +0900
Update squirrel to latest release
Quite a few fixes since our last update. See https://github.com/clowd/Clowd.Squirrel/releases.
Of special note is [a fix for incomplete updates](https://github.com/clowd/Clowd.Squirrel/issues/182)
which I believe we've seen cause issues in the wild before.
commit 00268d0ccce3691e682f7ae2ff08cb6a9a1f88f8
Author: Susko3 <Susko3@protonmail.com>
Date: Tue Nov 7 13:09:30 2023 +0100
Remove unused using
commit 7bedf7cf165e1a9a125eb74af636dca957e8fc0d
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 7 21:08:49 2023 +0900
Move static method to end of file
commit fcd73e62d2f98472e66524913c5f58fa2499d4f2
Author: Susko3 <Susko3@protonmail.com>
Date: Tue Nov 7 13:06:14 2023 +0100
Remove mobile specific changes
Will be added back in a separate PR
commit 38c9a98e67e421a965d5979425ace752517e63e2
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 7 10:52:48 2023 +0900
Add failing test coverage
commit 7385c3c97bb48b507127dd8709d658788adbaf78
Author: Susko3 <Susko3@protonmail.com>
Date: Tue Nov 7 00:17:15 2023 +0100
Move `InputSettings` children creation code to BDL
- Avoids now obsolete variable name
- Makes changing to touch detection easier (access to session statics in BDL)
commit 05d941871860fc94db9d92d722d44eb4f190766a
Author: Susko3 <Susko3@protonmail.com>
Date: Tue Nov 7 00:13:46 2023 +0100
Rename setting to `TouchDisableGameplayTaps` for better visibility when searching
commit 0dbba13686388559a25558ebbd4a4fd17c858e1d
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Tue Nov 7 01:59:00 2023 +0300
Split argon score sprite text and update combo counter design
commit 7c1c62ba8aef898bddaa6c07124a1053251bdf8a
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Tue Nov 7 01:58:26 2023 +0300
Remove argon combo wedge and update combo counter position
commit ce36884ef05dbe1664e93ef9285abb43b0849067
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Tue Nov 7 00:54:34 2023 +0300
Make score wireframes display up to required digits count
commit 4c7db4c2625483d557f1e4b6964579adcb7a0060
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Tue Nov 7 00:49:22 2023 +0300
Make score counter right-aligned
commit 754e05213c452f1f1ddc1c3485ae9e4270b23979
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Tue Nov 7 00:53:20 2023 +0300
Update argon score wedge design
commit 01e59d134a9b8436404a1c6de4bc5cb07332dfe8
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Tue Nov 7 00:48:51 2023 +0300
Adjust health bar settings on default components initialiser to match new layout
commit a4ac50cf86f8cbd148eedf75b765c65ad34301b6
Author: Susko3 <Susko3@protonmail.com>
Date: Mon Nov 6 21:10:04 2023 +0100
Revert "Rename popup/binding string to `Toggle gameplay clicks/taps`"
This reverts commit 0d8bfedf5d3693809e76471b9feb47ebf140e40b.
commit ed02335e3eb802c1865a653eac0af1b1050f3121
Merge: 9f6304b9ab a136f272cf
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 7 05:08:47 2023 +0900
Merge pull request #25377 from bdach/system-mod-better-colours
commit f8b5ecc92a2e303a87a23c218a24c103881cb8c5
Author: Susko3 <Susko3@protonmail.com>
Date: Mon Nov 6 21:07:15 2023 +0100
Update UI to use the new setting
commit ea357bafddd9970fb2c7f06686e1604b6caca76f
Author: Susko3 <Susko3@protonmail.com>
Date: Mon Nov 6 20:53:22 2023 +0100
Fix tests by using the correct setting for touch input
commit c1967a5cbb640cf296832efec00b392922c398c9
Author: Susko3 <Susko3@protonmail.com>
Date: Mon Nov 6 20:43:24 2023 +0100
Make tests fail
commit d6e7145e1c676ff45eb820f42375500cba43c3a1
Author: Susko3 <Susko3@protonmail.com>
Date: Mon Nov 6 20:42:40 2023 +0100
Add new setting for GameplayDisableTaps
commit 38d16f620cdef1ab457ce2b82c5c9d1d91113761
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Mon Nov 6 21:55:00 2023 +0300
Alter test case to comply with new behaviour
commit b2749943e27ae31fb392b1bbad918cbd9432412e
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Mon Nov 6 21:52:46 2023 +0300
Display "required save" popup when creating another difficulty on a new beatmap
commit 944fee56f8d8e61895882a5c55c9d6ff0e6c637e
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Mon Nov 6 21:48:47 2023 +0300
Add failing test case
commit 9d10d93085cd3cde44d63836911bc607d5618901
Author: Andrei Zavatski <megaman9919@gmail.com>
Date: Mon Nov 6 20:45:52 2023 +0300
Adjust test scene to see graph flickering
commit a136f272cf78ec3572bc13bdcf0de47b74789a73
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 16:40:57 2023 +0100
Just use yellow for system mods
commit 073249dafb3605a36bb8482f73f2dac1b7733b9f
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Mon Nov 6 18:35:46 2023 +0300
Allow tinkering with cursor-related settings in resume overlay test scene
commit e12ee29a942279becf7ca4fd3816af1787b3fce8
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Mon Nov 6 18:35:30 2023 +0300
Update existing test coverage
commit 75fbbb35ad2f88524670a19312dcb43569db8190
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Mon Nov 6 18:28:51 2023 +0300
Move cursor scale application within `OsuCursor`
Doing so takes down two birds with one stone.
1. `ResumeOverlay` having to manually apply cursor scale to its "resume
cursor".
2. Resume cursor input handling scaling up with the gameplay setting. Now, only the sprite itself gets scaled.
commit 915feeffb05389da36e9eb4e1c75f962202b3703
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Mon Nov 6 17:37:25 2023 +0300
Revert gameplay cursor scale changes
commit f897c21b3f5b57b5892f25cef3644aabf82d7c43
Author: Joshua Hegedus <josh.hegedus@outlook.com>
Date: Mon Nov 6 15:25:12 2023 +0100
partial change
commit a01f6187f4738f85376cb820315d95d8c4545e4c
Author: Joshua Hegedus <josh.hegedus@outlook.com>
Date: Mon Nov 6 14:52:06 2023 +0100
testing the tooltip
commit 9f6304b9ab612bcdb24c5eb33101f818b9d60909
Merge: 408ae84111 51c891e2e4
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 12:40:11 2023 +0100
Merge pull request #25376 from peppy/verify-screen-refresh-on-enter
Automatically refresh the verify screen's issue list on re-entering it
commit 4bc36a6c90dfd051cd6202be7e4fec48c1b05080
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 12:18:02 2023 +0100
Fix unused variable
commit 034f53da4b1d79220d8af95055a203076ab88c87
Author: Joshua Hegedus <josh.hegedus@outlook.com>
Date: Mon Nov 6 11:54:57 2023 +0100
added isEnabled to tooltip
commit 39ad91feea58e0a91e95b3a2be0889ff98be4ce6
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 11:50:04 2023 +0100
Make debug input toggle post notifications
commit 6deac9a5a45319d1536a9dc223a4efb07324a63c
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 11:24:56 2023 +0100
Use better colours for system mods
commit 51c891e2e4ff17432a01bf4f9ee75ad8c1498883
Author: Dean Herbert <pe@ppy.sh>
Date: Mon Nov 6 19:34:34 2023 +0900
Automatically refresh the verify screen's issue list on re-entering it
Addresses https://github.com/ppy/osu/discussions/25365.
commit 718492a0b7d9c38b32102095c84393fbe5a792d9
Author: Joshua Hegedus <josh.hegedus@outlook.com>
Date: Mon Nov 6 11:29:15 2023 +0100
fixed DRY
commit 682668ccf0f73bdbb98b800afcaff983399d391d
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 10:54:32 2023 +0100
Remove touch device toasts entirely
commit 92e4a8666def6e4bcc66d008ca0d206ca6c6cbd8
Author: Dean Herbert <pe@ppy.sh>
Date: Mon Nov 6 18:43:47 2023 +0900
Add `spinnerbonus-max` support and fallback to `spinnerbonus`
commit b219a371a93d82c3638df3b47f51e85d20f1fb94
Author: Dean Herbert <pe@ppy.sh>
Date: Mon Nov 6 18:29:51 2023 +0900
Move sample playback logic local to avoid edge case with no bonus ticks
Can't see a better way of doing this.
commit 86cf0a36cfb842cf97f074988a28c9958e9b0b81
Author: Dean Herbert <pe@ppy.sh>
Date: Mon Nov 6 18:16:31 2023 +0900
Add test coverage of spinner with no bonus ticks
commit aa6f14b0247f2fe0768379b9a1ae03f75827ba86
Author: Dean Herbert <pe@ppy.sh>
Date: Mon Nov 6 18:16:04 2023 +0900
Fix spinner test hitting assertion when spinning too fast
commit 204cd541e2b8876089c619abd94e97baafb97b8b
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 10:14:56 2023 +0100
Use placeholder mod icon for touch device
commit 97fee6143c7b81d169452396a490b8293b521527
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 10:08:19 2023 +0100
Rename touch "input handlers" to detectors
commit 408ae841110854b17c963beb67c7aa68e9f55555
Merge: 41cd9a4db6 1f0b914251
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 09:38:48 2023 +0100
Merge pull request #25375 from peppy/reset-rotation-skin-editor
Add skin editor dropdown items to reset rotation and scale
commit 41cd9a4db615290f557c664b9151c1c48ef64667
Merge: 5ef8500d2a 69d6feb5a8
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 09:34:11 2023 +0100
Merge pull request #25374 from peppy/add-skinnable-player-name
Add player name skin component
commit e2928cc6b96f816320f238e5f653bd75c5ed9ca3
Author: Dean Herbert <pe@ppy.sh>
Date: Mon Nov 6 17:32:39 2023 +0900
Fix incorrect assertion check targets (and flip assertion for miss case)
commit 4a70f2435c574b82829a5d2508ae29f7d2e3a2fb
Author: Joshua Hegedus <josh.hegedus@outlook.com>
Date: Mon Nov 6 09:22:50 2023 +0100
fixed showUsernameTooltip
commit 5ef8500d2ac66aaa647833d2fe07faa8b9315fcb
Merge: bc9cdb4ce0 0915ac8891
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 09:19:49 2023 +0100
Merge pull request #25349 from Joehuu/argon-key-counter-upright
Keep `ArgonKeyCounterDisplay` text upright
commit b62811633f07820848ec960e228989f02e30f68c
Author: Dean Herbert <pe@ppy.sh>
Date: Mon Nov 6 17:17:19 2023 +0900
Add test coverage of touching and missing not enabled touch mod
commit 69d6feb5a8b9137aaf74956945b897d7741fe3a3
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 08:51:31 2023 +0100
Add test coverage for player name skin component
commit b45d8c785cd662796c6098f72aadf589b99161e4
Author: Joshua Hegedus <josh.hegedus@outlook.com>
Date: Mon Nov 6 08:38:34 2023 +0100
fixed review findings
commit 0915ac8891f1a5036a325d95b870d29c0daeb733
Author: Dean Herbert <pe@ppy.sh>
Date: Mon Nov 6 16:32:12 2023 +0900
Use left aligned text for non-rotate key counter
commit 1f0b914251bc61d82bf9e3db207e75399a600806
Author: Dean Herbert <pe@ppy.sh>
Date: Mon Nov 6 16:18:33 2023 +0900
Add skin editor dropdown items to reset rotation and scale
commit 40d081ee2de0940600f94ff126259b019622483b
Author: Dean Herbert <pe@ppy.sh>
Date: Mon Nov 6 16:05:50 2023 +0900
Add note about `Width` requirement in `UserGridPanel`
commit 7ba07ab5305dc0be39bddc06967d826e36bfeea8
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 08:05:42 2023 +0100
Add protections against handling system mods in mod presets
commit adb9ca5a13cb920c6554457392a9f715b85038ee
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 07:56:09 2023 +0100
Add failing test coverage for incorrect treatment of TD in mod presets
commit 3c72c5bccd21b4127ceaae9346ec04e6b059db9f
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 07:48:09 2023 +0100
Steer touch input flag via bindable rather than config manager
commit 11bd801795f5a838cfc478e486586476fed2eb30
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 07:44:25 2023 +0100
Use more intelligent default for `TouchInputActive`
commit febd004bda4a0d17d9e14f7250bb1aeebf86455e
Merge: a78fab0e7d bc9cdb4ce0
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 07:41:35 2023 +0100
Merge branch 'master' into less-basic-touchscreen-detection
commit e2b07628fb5719540ea3d1405de25a83b469b8da
Author: Dean Herbert <pe@ppy.sh>
Date: Mon Nov 6 15:24:12 2023 +0900
Add player name skin component
3 minute implementation.
Addresses https://github.com/ppy/osu/discussions/25340.
commit 9947897c5f83c7298c381015a95673902486b52d
Author: Susko3 <Susko3@protonmail.com>
Date: Sun Nov 5 12:53:40 2023 +0100
Use appropriate clicks/taps text in player loader input settings
commit 0d8bfedf5d3693809e76471b9feb47ebf140e40b
Author: Susko3 <Susko3@protonmail.com>
Date: Sun Nov 5 12:44:22 2023 +0100
Rename popup/binding string to `Toggle gameplay clicks/taps`
commit fa1d1df594d3f5307e01207952c4eb6be7ee3494
Author: Susko3 <Susko3@protonmail.com>
Date: Sun Nov 5 12:43:14 2023 +0100
Rename mouse button string to `Disable clicks during gameplay`
commit 86fb33cb90b500dba57b2c199b381e7e8473b558
Author: Susko3 <Susko3@protonmail.com>
Date: Sun Nov 5 12:40:06 2023 +0100
Add disable taps checkbox to touch input settings
commit 9cb331641c39b9a1b54b192be3420e0db8b7ba68
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Sun Nov 5 06:34:09 2023 +0300
Rename container
commit 99405a2bbd38e999672d0fe89c83e56b845a0bdf
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Sun Nov 5 06:28:34 2023 +0300
Tidy up resume overlay test scene
commit 48a75f6152705c5377b116f0dc2b6cf598036bb3
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Sun Nov 5 06:28:10 2023 +0300
Fix resume cursor following gameplay cursor scale setting
commit 634795e45f12676c277be583bad61c29cc3ec22a
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Sun Nov 5 02:50:14 2023 +0300
Adjust failing test scenes
commit 1d4f4cf4c362e0766e92231714c6431900fbc1b7
Merge: 77f5a4cdf5 bc9cdb4ce0
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Sun Nov 5 02:02:36 2023 +0300
Merge branch 'master' into gameplay-hud-redesign/counters
commit 77f5a4cdf53fca660a71140b84c9897439ddbf2e
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Sun Nov 5 02:01:26 2023 +0300
Update skin deserialisation archive
commit 6c3169a0ed6e9f0f9e1e7d668993e04861f63540
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Sun Nov 5 01:56:45 2023 +0300
Remove PP wedge and logic for gameplay layout
commit a23dfbeab55bb3e195407bcf436444f150d5a355
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Sun Nov 5 01:55:13 2023 +0300
Revert "Abstractify PP counter logic from the "Triangles" implementation"
This reverts commit daf4a03fd092ac84955a8f63fa3c45200a28cf04.
commit 58a830fc5b2bd749ebccd7cf1b5e0f12b6f4c117
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Sun Nov 5 01:55:12 2023 +0300
Revert "Add "Argon" performance points counter"
This reverts commit 56eeb117ce2011ad4b80cf32c3b015eb482d7c9b.
commit 1c844a155e97059e23cdae6470401d217fa88db3
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Sun Nov 5 01:52:12 2023 +0300
Remove health line detail
commit 91cf237fc12fcbecc6d1345310717407f559a32e
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Sat Nov 4 02:46:28 2023 +0300
Revert health display settings changes
commit ec290ae953c9dffec44bb71e1fcde4e0785ef843
Author: Joshua Hegedus <josh.hegedus@outlook.com>
Date: Sat Nov 4 19:03:23 2023 +0100
added tests
commit a70bfca501312bc587c230064a6269b20a714c82
Author: Joshua Hegedus <josh.hegedus@outlook.com>
Date: Thu Nov 2 09:16:25 2023 +0100
added usergrid for tooltip
commit d3c5988bf14f42b31064342c211ade4b7024b858
Merge: 818432fab4 bc9cdb4ce0
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 3 09:11:39 2023 +0100
Merge branch 'master' into slider-combo-matching-2
commit 3f8baf913b46b884d9cbb5530721d58913403b5a
Author: Joseph Madamba <madamba.joehu@outlook.com>
Date: Thu Nov 2 19:46:09 2023 -0700
Add 100 and 1000 key press step to test overflow
commit e3b3ce6c84102e34778c4fd25bb39e366dc0977f
Author: Joseph Madamba <madamba.joehu@outlook.com>
Date: Thu Nov 2 18:44:56 2023 -0700
Fix test overflowing on widescreen + add default (triangles) key counter testing
commit 16731ff85ff90b8c9e20b40b0358bc2c128782c2
Author: Joseph Madamba <madamba.joehu@outlook.com>
Date: Thu Nov 2 18:20:15 2023 -0700
Fix text positioning
commit b3dfe19472a2a6a7f7d2b2d34570036df8f6b49c
Author: Joseph Madamba <madamba.joehu@outlook.com>
Date: Thu Nov 2 18:17:25 2023 -0700
Fix `UprightAspectMaintainingContainer` not being centred
commit 090601b485bdec297ef3d723f7254b54ca335d3b
Author: Joseph Madamba <madamba.joehu@outlook.com>
Date: Thu Nov 2 18:12:39 2023 -0700
Apply peppy's upright key counter attempt diff
Co-Authored-By: Dean Herbert <pe@ppy.sh>
commit bc9cdb4ce07fcc7fc16117121f6bb620a8094c36
Merge: efb4458061 a0757ce13f
Author: Dan Balasescu <smoogipoo@smgi.me>
Date: Fri Nov 3 11:27:22 2023 +0900
Merge pull request #25341 from peppy/slider-combo-matching
Rename and invert flags for slider classic behaviours
commit a78fab0e7d74d41b58ecefbe74854370ffee08c9
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 3 00:17:29 2023 +0100
Do not hardcode ruleset name in touch device detection toast
commit a613292802ce0fe5f53b31de761e6dcdf3135113
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 2 23:44:40 2023 +0100
Fix unknown mod test failure
commit 8e9006b5d5c263cf79fed1e74532e7de5dfca122
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 2 22:27:16 2023 +0100
Declare Touch Device incompatible with Autopilot
With Autopilot active, Touch Device no longer matters.
commit 0dd0a84312e224bb2cb5396cdc479e2b04688000
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 2 22:26:52 2023 +0100
Move player touch handler to `SubmittingPlayer`
Shouldn't be there in `ReplayPlayer`.
commit 8784dd42c0c4c1aba37cb0cc4f5cda8055811a69
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 2 22:20:17 2023 +0100
Do not attempt to turn on Touch Device in song select with autoplay active
commit d25b54c06d660455484762a011c162c6cb68dfd7
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 2 22:14:38 2023 +0100
Split test into two
They would fail on CI when written as one, and I don't care why.
commit 3a6d65d395c1bf3c0e30429fec90be5e4fedb7c3
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 2 19:51:21 2023 +0100
Touch up `PlayerTouchInputHandler`
commit 4532d0ecdf12abd32b3d64cbab3b9e975f34c63d
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 2 19:48:34 2023 +0100
Add logging & debug facility for touch input interceptor
commit c588f434e5f51bee3683c6114bc951fda40fb50c
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Tue Oct 31 13:54:18 2023 +0100
Fix song select touch handler causing crashes when song select is suspended
commit ef555ed0cf442b98cb139de435e0e0815468c05e
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Oct 30 15:48:00 2023 +0100
Fix test failures
commit 21a4da463b11d557a815581cdb09121a9ea0a94d
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Tue Oct 31 13:47:50 2023 +0100
Add failing test covering crash scenario
commit f2df02b60f7e78a4e1fad2c591c24dfe14271c1f
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Wed Oct 25 20:27:07 2023 +0200
Automatically activate touch device mod in player
commit 29d4d81eaab886e0f99bd2c579a1425a41b4b17f
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Wed Oct 25 19:56:51 2023 +0200
Add test scene for basic touchscreen detection scenarios
commit 2f6ff893b550a18ec1f4791d45c96c5dcb3e99cb
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Oct 30 14:38:20 2023 +0100
Automatically activate and deactivate touch device mod in song select
commit 980c900f43aa958e25d519e687a4a2e224d2399c
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Oct 30 14:08:56 2023 +0100
Add component for game-wide touch detection
commit 68efb3c110aa3617fb801cb8afe6b7fb15afcba1
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 2 19:25:57 2023 +0100
Mark `ModTouchDevice` as always valid for submission
commit 9f11a04cc731159c6d2c0e4f7084238f6bd88360
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Oct 30 13:24:01 2023 +0100
Generalise notion of 'touch device' mod
commit a0757ce13f3156c526d51b7d3be6afcd47436230
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 2 18:58:14 2023 +0100
Update xmldoc to match flipped flag semantics
commit 86ede717cbeb705a7036276b49e5c53aeb6ecc53
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 2 18:52:47 2023 +0100
Clean up comment
commit ac6fb386d137a13eae242fa65cf417e3d6ec4abb
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 2 23:42:52 2023 +0900
Remove nested ternary
commit efb4458061f8eb3d9e04d1465ad6bf333c3e6500
Merge: e18d0b64de 998d709331
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 2 12:40:57 2023 +0100
Merge pull request #25336 from peppy/mania-key-expand-mobile
Add support for "argon" default skin to expand columns when on mobile devices
commit 998d70933150c71e0cdbb5ebe4f968006ae30ebe
Merge: 704f5a6de3 e18d0b64de
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 2 11:59:01 2023 +0100
Merge branch 'master' into mania-key-expand-mobile
commit f0f595ca40ab02cd0637a50ce0246d05423fc0c6
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 2 19:52:49 2023 +0900
Continue to play spinner bonus sounds when MAX display occurs
commit 704f5a6de3a4dba381efc0dc62a77ce1cb166f7a
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 2 19:40:20 2023 +0900
Adjust sizing slightly to ensure we stay within 1366 limits
commit 818432fab4279b6691286483b6be88eb663e84c3
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 2 19:27:55 2023 +0900
Fix non-classic osu! combo not matching expectations
commit e18d0b64de9ee5cb67328818c92d983ee346c514
Merge: 64feea80db c83589cb74
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 2 10:46:32 2023 +0100
Merge pull request #25338 from peppy/mania-mod-ordering
Change osu!mania conversion mod ordering to be more appeasing
commit bf9f20705f06e3094ae7e772f4ac59fa45472856
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 2 17:39:23 2023 +0900
Simplify classic behaviour flag to only need to be specified on the slider itself
commit a7705284e7b56bcedaee756ec8f37432f029d62c
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 2 18:02:47 2023 +0900
Add better commenting around `DrawableSliderHead` logic
commit 9af2a5930cf3696ffecea558e94bcec01b642ace
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 2 17:39:41 2023 +0900
Remove redundant passing of `Scale` to nested objects
commit 9c1f4b552e651a8d163cd7adf17a0c6ff3e49f08
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 2 17:04:49 2023 +0900
Rename and invert flags for slider classic behaviours
commit 64feea80dba69cccaba2e3a4db79ba9cc9e1e0e8
Merge: b7ab886848 48bdeaeff1
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 2 09:32:09 2023 +0100
Merge pull request #25334 from peppy/fix-bubble-crash-again
Fix another potential crash in bubbles mod
commit b7ab88684846ee21e279c1f96be0b3ab5ffcf955
Merge: 57d8b5ddc9 ad82ada030
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 2 09:07:44 2023 +0100
Merge pull request #25333 from peppy/fix-spinner-performance
Fix all spinner ticks being alive and causing performance degradation
commit ad82ada030715427397d6ef5b0a08b475dbfef31
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 2 08:18:37 2023 +0100
Trim redundant comments
commit c83589cb742db95d7fb21df6aa2c00836a01be89
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 2 15:49:10 2023 +0900
Change osu!mania conversion mod ordering to be more appeasing
commit 6dab5ee4cfbad32710777b649d5fd5e6cc1d2c3e
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 2 15:13:43 2023 +0900
Add support for "argon" default skin to expand columns when on mobile device
Should ease those looking to play the game on mobile until we
(potentially) have a better solution in the future.
If this works out well, we can consider rolling it out to other skins.
Closes https://github.com/ppy/osu/issues/23377.
commit 48bdeaeff14f456abb371878307c91d79156832e
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 2 02:42:36 2023 +0900
Fix another potential crash in bubbles mod
Storing `DrawableHitObject` for later use is not safe – especially
when accessing `HitObject` – as it's a pooled class. In the case here,
it's important to note that `PrepareForUse` can be called a frame or
more later in execution, which made this unsafe.
Closes https://github.com/ppy/osu/issues/24444.
commit c2de03aa44c85fccb29e5542c63c01d46dc7145d
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 1 18:28:05 2023 +0900
Fix all spinner ticks being alive and causing performance degradation
Regressed in https://github.com/ppy/osu/pull/25216.
The new logic will ensure at least one tick is ready for judgement.
There shouldn't be a case where more than one is needed in a single
frame.
commit 57d8b5ddc9989eceeff02bdc5c2b4d40514be336
Merge: 95d8ee8e9b a90f8dd4f6
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 1 15:48:47 2023 +0900
Merge pull request #25328 from bdach/mod-cleanups-docs
Clean up mod usability flags
commit a90f8dd4f63191209d593201a2bb1a00b7828a37
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Tue Oct 31 16:20:33 2023 +0100
Seal a few more multiplayer playability flags of rate-changing mods
Not really changing anything, just tightening things down to curb
possible funny business.
commit 955e2ed05166aeaf6073938661a9bc7197d9b816
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Tue Oct 31 16:18:09 2023 +0100
Seal `UnknownMod`
Not a class for extension.
commit a644c75957247c8f16674ea47e1eec4a239f1159
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Tue Oct 31 16:16:57 2023 +0100
Mark `ModScoreV2` as invalid for multiplayer
Doesn't do much for the client; mostly a safety for osu-web's sake,
as without the change it could theoretically fail to validate the mod
properly in multiplayer contexts.
commit 456f4ebba2208d4a764df157d02dcbbbe6dda544
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Tue Oct 31 16:16:14 2023 +0100
Seal `ModScoreV2`
Nobody should ever need to extend it.
commit 3a2645efb17dbe9bee7251b4a8ecc0868cf8799d
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Tue Oct 31 16:15:10 2023 +0100
Seal `ModAutoplay` playability flags
Can't do much more than that due to the unfortunate fact of Cinema
inheriting from Autoplay.
commit 7ea298a1b6a4f17a8ae3b505c599f04ac498e4ce
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Tue Oct 31 16:13:44 2023 +0100
Add xmldoc to `Mod` playability flags
commit 95d8ee8e9bdf17df06ff0c20ba9d6881e474e96c
Merge: bc2acc3e93 9f5a280bc2
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Oct 31 22:13:42 2023 +0900
Merge pull request #25323 from bdach/fix-key-binding-test-failures
Fix key binding row fire-and-forgetting writes
commit 9f5a280bc22b1f88d20b7b885d4aa252f7feee7c
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Tue Oct 31 12:25:08 2023 +0100
Fix key binding row fire-and-forgetting writes
Intends to fix test failures as seen in https://github.com/ppy/osu/actions/runs/6692350567/job/18181352642#step:5:129
This is what happens if you carelessly fire and forget.
The working theory (that I'm not sure I have the tools to conclusively
confirm) is that the async write from the key binding changing could
fire _after_ the section is reset.
I briefly considered having the test wait for the change, but given that
the entirety of the surrounding flow is using sync operations, this just
looks like a bug to me. And there's no real sane way to inject async
into that flow due to dependence on `OsuButton.Action`.
commit bc2acc3e93072336e3a06a437a6a8824e85d34c8
Merge: 850866e7f4 0d44b5af90
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Tue Oct 31 11:02:59 2023 +0100
Merge pull request #25318 from peppy/fix-follow-point-scrathces
Fix potential texture corruption when cropping gameplay textures of weird aspect ratios
commit 850866e7f4ba91fba5eb09a9fd18dcb904902f6a
Merge: 84fb0c63e5 64efc3d251
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Tue Oct 31 09:37:29 2023 +0100
Merge pull request #25316 from peppy/metronome-alwa…
xdi1
added a commit
to xdi1/osu
that referenced
this pull request
Nov 21, 2023
commit 4b5ef8328bdd846752495c00e3310e388cdfb3cf
Merge: 21bf288277 c9ee29028f
Author: Dan Balasescu <smoogipoo@smgi.me>
Date: Tue Nov 21 18:00:19 2023 +0900
Merge pull request #25521 from Syriiin/fix/refactor-miss
Fix implicitly used method being named incorrectly
commit 21bf288277e08044e88bdc33ce53a779b293c617
Merge: bf972a04ee ed38746823
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 16:56:36 2023 +0900
Merge pull request #25520 from peppy/context-menu-spacers
Allow context menus to have visible spacers
commit bf972a04eebb9c20cc548ec4de2683bedbbd0da6
Merge: d83b2e24e7 4b2d8aa6a6
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Tue Nov 21 16:28:14 2023 +0900
Merge pull request #25409 from Tom94/bspline-sliders
Add free-hand drawing of sliders to the editor
commit ed3874682365596f96fac6c8622821786b3645a5
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Tue Nov 21 16:14:30 2023 +0900
Fix spacer appearing on top of menu
commit d83b2e24e7eabb1bc79c9857dd3f631f4497d24d
Merge: 3d569850b1 7c5345bf7e
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Tue Nov 21 15:48:36 2023 +0900
Merge pull request #25371 from RatinFX/open-editor-timestamp
Implement opening editor timestamp links
commit 4b2d8aa6a647b28c13f63dc3047cca04b8b8c398
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 15:31:39 2023 +0900
Add `ToString` on `PathType` for better test output
commit cc33e121258adb0d607fba5c6bf9897e1979eac5
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 15:16:40 2023 +0900
Fix dragging after one point already placed incorrectly entering drawing mode
commit 1660eb3c15b1075e93a64a2938e8e86451f5df84
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 15:31:24 2023 +0900
Add failing test coverage of drag after point placement
commit a210469956ca340bb302f76679c49142e2e0ae69
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 14:52:21 2023 +0900
Reorder methods
commit 016de7be6a9c0a5709e966b6f2bb45349d8f38e8
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 14:51:09 2023 +0900
Simplify drag handling code in `SliderPlacementBlueprint`
commit cf6f66b84f729a71e04a34b7d9acf9091dfbd7cb
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 14:37:06 2023 +0900
Remove redundant `Clear()` call
commit 92728ea56460dfe0c2135d9165ee8d35e49fe8ad
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 14:10:48 2023 +0900
Simplify toolbox initialisation
commit ba6fbbe43c122413c4b4b81eb9450e77f3361f8b
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 14:03:45 2023 +0900
Update framework
commit 3d094f84add9f669b2bf0e1bd41bd83da4fd01fd
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 14:02:15 2023 +0900
Fix incorrect parsing of BSpline curve types
commit 9c3f9db31838295cccc0ea4f771933dbb4fa2dc7
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 14:02:08 2023 +0900
Add failing test coverage of BSpline encoding parse failure
commit 7bedbe42642384a20b681220b507fcc737325c1e
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 13:36:06 2023 +0900
Apply NRT to `SliderPlacementBlueprint` tests
commit 5175464c18dafc3931b723ae06dbb4375c7c0a77
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 13:35:04 2023 +0900
Update test coverage (and add test coverage of curve drawing)
commit e69e78ad4123a4d89915aa44286a8e637e49429d
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 13:10:44 2023 +0900
Refactor b-spline path conversion code to better handle linear segments
commit 0a5444d091de73c2cc9fe8360146248d1b06b39e
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 13:05:31 2023 +0900
Fix using the incorrect position for the first point
commit 314a7bf6f1058195ecf5995fc18a5e5bc1eb94fe
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 11:33:05 2023 +0900
Simplify `AddOnce` call to avoid `self` argument
commit 7c5345bf7e88ba364cd3606e424f4ae45b6760f2
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 15:09:33 2023 +0900
Use `SimpleErrorNotification` for error display
commit 917a68eac3273f969a7b760cd7a258e475fcc23e
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 15:08:15 2023 +0900
Adjust localisablel strings and keys
commit 3afaafb1d9a19692cbd6750eda24cbd7d920c7d2
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 15:05:51 2023 +0900
Reorder and simplify private helper methods
commit c9ee29028fbcf3056c82d5b5c182f862f68974fa
Author: Samuel Cattini-Schultz <syriiins@gmail.com>
Date: Tue Nov 21 16:54:20 2023 +1100
Fix implicitly used method being named incorrectly
commit 9718a802490519780c3d88f55a90037a20b26421
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 14:24:19 2023 +0900
Add visible spacer between "inherit" and other curve types
commit 405ab499e9dfd7c75477513aa38b344ffb901781
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 14:24:10 2023 +0900
Allow context menus to have visible spacers
commit 3680024e3102d5dcca617371105d4c3bf3787945
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 11:15:00 2023 +0900
Fix tolerance not being transferred to blueprint in all cases
commit e9f371a5811b72763a50fc1e5fffba5ef95e081f
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 09:59:49 2023 +0900
Refactor slider settings class
commit 638c8f1adc2e135aff574e135c515adfbf384423
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 00:25:23 2023 +0900
Get rid of weird cruft and non-standard flow
commit 6f5c468a83cd0341616d01d10ef5345568a7d943
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 00:21:44 2023 +0900
Rename settings class
commit 750bbc8a19cfdb0f1c3133e9bd86e02bacb51f0d
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 21 00:17:25 2023 +0900
Simplify null checks
commit 745a04a243b90a1b83da308ea3e8e6467c9faacc
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 22:12:15 2023 +0900
More test cleanup
commit a8fc73695f30b3d22c260c8ea030f3034d1c21d5
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 22:04:08 2023 +0900
Rename variable
commit 364a3f75e15001b785f185c41ba69e28edecf926
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 22:03:25 2023 +0900
Compile regexes
commit c16afeb34700b22a09932ad792ae801c0c5bffb9
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 21:57:07 2023 +0900
Fix tests
commit b6215b2809aac10f2bbf82403b76c6ca37f8d285
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 21:37:29 2023 +0900
Rename and document `SelectFromTimestamp`
commit 234ef6f92379b3cbf0c9a07f2334f2a068f9fe95
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 21:34:36 2023 +0900
Rectify selection keep-alive logic
commit 246aacb216d692b7bc54ae7fccebfd5869561d82
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 21:29:19 2023 +0900
Remove unnecessary guard
Setting a bindable's value to something if that value is already there
is a no-op (doesn't trigger bindings / callbacks).
commit 0e0ab66148ec99a0458b5102541e1a58206a2887
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 21:27:24 2023 +0900
Simplify parsing code
Less methods, less smeared around logic, saner data types.
commit c9e8d66e1970fa8498761b4fb5fe868bf879d1d7
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 21:02:12 2023 +0900
Improve xmldoc
commit 492fd06c624b2d8d8ff65464798bcde72c4fd51c
Author: Dean Herbert <pe@ppy.sh>
Date: Mon Nov 20 19:21:23 2023 +0900
Remove unnecessary null override
commit 3d569850b15ad66b3c95e009f173298d65a8e3de
Merge: aeb1aaf97a 66f7b9fae1
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 17:58:15 2023 +0900
Merge pull request #25493 from peppy/adjust-slider-tick-animation
Adjust slider follow circle animation to not abruptly scale on early ticks
commit ded9981d07b8bc54fd43a53a76f6335aab5d636f
Author: Dean Herbert <pe@ppy.sh>
Date: Mon Nov 20 17:55:01 2023 +0900
Update framework
commit 7633c92a78b8341411fc0e3185efc2118bf09fc5
Merge: 4061417ac8 aeb1aaf97a
Author: Dean Herbert <pe@ppy.sh>
Date: Mon Nov 20 17:53:58 2023 +0900
Merge branch 'master' into bspline-sliders
commit 4061417ac8cff9242cf5582fdb8b173f7095059e
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 15:54:43 2023 +0900
Decrease default value for slider tolerance
Highly subjective change, but at 50 the drawing just did not feel
responsive enough to input.
commit 43dbd65708de80e4e671e042e76496ffb7526d57
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 15:53:25 2023 +0900
Show Catmull as a control point type option if selection already contains it
commit 8e39dbbff1898830ab70c5b418ec31b661fede42
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 15:41:26 2023 +0900
Adjust casing of curve type menu items
The "Perfect curve" one in particular... fixes test failures, as some
tests were relying on this particular casing. But the new version feels
more correct anyway, so it's whatever.
commit 5f302662be30eff9eb12318c40651f1f776fb09c
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 15:34:23 2023 +0900
Remove test terminally broken by introduction of slider drawing
commit 46d4587c97fc8a6d7b3a2ea0e98366fe149f2ed3
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 15:34:01 2023 +0900
Add test for slider drawing
commit 6d7d826b8b76f775bf59d600d493912a92950540
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 15:08:58 2023 +0900
Fix incorrect legacy conversion when B-splines are used
commit 80a3225bb28f315aeceda4dc5e10c2222faa0e1f
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 13:35:07 2023 +0900
Use static `BEZIER` instead of allocating new every time
commit 487326a4c786aa89b597ea191ec83c701386736d
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 13:22:36 2023 +0900
Remove pattern matching syntax usage in switch
Also throw on unknown types.
commit 5d1bac6d7a55a980e608fbf6bfa8744ceb30b18f
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 13:17:43 2023 +0900
Remove `IToolboxAttachment` for now
The interface doesn't really do anything useful right now because
it enforces a common contract, but all usages of the contract
go through the concrete implementation, and it inflates
the already-huge diff.
commit affef85f2521246412949531e291fdbed4cf1272
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 13:02:51 2023 +0900
Remove `ISliderDrawingSettingsProvider`
Seems like excessive abstraction.
commit 831884a64b74113f76bc59eed0466f232b71f7aa
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 13:00:12 2023 +0900
Remove unused enum member
commit f46945a29439716ef10e5e82277cf5e338044094
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 12:42:16 2023 +0900
Avoid one unnecessary path update from B-spline builder
commit 518dcc567b14cdf8ade2d449b20cdcbcfcf45e98
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 12:41:22 2023 +0900
Null-check `drawingSettingsProvider`
As it's annotated as an optional dependency.
commit 7820c8ce4d558381f80444fcf3fb38035382a852
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 12:28:20 2023 +0900
Decrease redundancy of equality implementations
commit 25c1a900473de216ba5c07b306b4e49316ec7828
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 12:25:44 2023 +0900
Change switchexpr to standard switch statement
commit 577cb9994ce54202bf2c07548389f0e6b701fa8f
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 12:24:32 2023 +0900
Move static instances / construction methods closer together
commit aeb1aaf97a98c30c22646fa4d0ab3fcc1642c2f2
Merge: 166518db7a 6304ba18e5
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 12:21:35 2023 +0900
Merge pull request #25490 from peppy/auto-generator-spm
Refactor `OsuAutoGenerator` to allow custom SPM specifications
commit 33b592f1c723fb4824f2084337de9dbb940d2b1f
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 12:04:30 2023 +0900
Update framework (again)
commit b6e3e42445f55de1dd7787a9d95716ac0f717425
Merge: 360864fd7b 166518db7a
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 12:03:29 2023 +0900
Merge branch 'master' into bspline-sliders
commit 6304ba18e55ff0aeb5e3257bc73fb40eb06b5971
Merge: e182acf3e8 166518db7a
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 11:50:44 2023 +0900
Merge branch 'master' into auto-generator-spm
commit e182acf3e8c012fe36f8317d70ca7d6abe1803e9
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 20 11:50:28 2023 +0900
Expand comment for clarification
commit 307ec172cbcc49f0edf26aed318d5390666faafa
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 17 23:48:48 2023 +0900
Use simplified formula
commit 166518db7a84ce5619b7ee74a014651dd9256f22
Merge: dee6a79911 bd932a5417
Author: Dan Balasescu <smoogipoo@smgi.me>
Date: Fri Nov 17 20:12:24 2023 +0900
Merge pull request #25491 from peppy/update-localisation-analyser
Update localisation analyser
commit 66f7b9fae1e0aaf86609bdbf3315870198e0f8b2
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 17 19:09:24 2023 +0900
Adjust slider follow circle animation to not abruptly scale on early ticks
commit bd932a5417dd7bc4fba8b237832d556c27ea0d9b
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 17 17:07:21 2023 +0900
Update localisation analyser
Pulls in https://github.com/ppy/osu-localisation-analyser/pull/60.
commit a1673160f12e08612aa42a9db89f8b9f2e6324f0
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 17 16:44:11 2023 +0900
Refactor `OsuAutoGenerator` to allow custom SPM specifications
commit dee6a799113fe24f5acab7088c5d0e0c305adad3
Merge: 87a76b9ee8 b88e3cd26f
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 16 22:25:14 2023 +0900
Merge pull request #25481 from peppy/make-skin-store-fallback
Change `ResourceStore` provided to `Skin` to be a fallback, not replacement
commit b88e3cd26f8eb3f7b90e8bc6a96097ae23d3773e
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 16 20:16:23 2023 +0900
Change `ResourceStore` provided to `Skin` to be a fallback, not replacement
commit 87a76b9ee80055a85cb51a12e0a70083c1ba63e2
Merge: 0a8ede6274 dc2d574965
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 16 17:39:35 2023 +0900
Merge pull request #25478 from Joehuu/fix-comment-markdown
Fix `CommentMarkdownTextFlowContainer` not inheriting osu! class
commit 0a8ede627465586c54ad324eb140a268f77da353
Merge: d09d58639a b45872d2e0
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 16 17:01:03 2023 +0900
Merge pull request #25469 from Joehuu/argon-hide-counter-labels
Add ability to toggle labels on argon counter components
commit d09d58639ae0cd07bf472d05b32aaee50827e81a
Merge: 4642b916b0 1e2f1b3ef2
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 16 16:47:03 2023 +0900
Merge pull request #25400 from frenzibyte/unload-main-menu-storyboard
Unload beatmap storyboards when not in main menu screen
commit 1e2f1b3ef202d3a7f80274f1c87725e41287c5c2
Merge: dbd4f26436 4642b916b0
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 16 15:46:44 2023 +0900
Merge branch 'master' into unload-main-menu-storyboard
commit dbd4f26436c988a8d1e1afb6e893e82fedb25460
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 16 15:37:53 2023 +0900
Use alternative method of scheduling storyboard unload
commit b45872d2e0f901e65c6e44cc0439f29b562f3785
Merge: 73eda6c09c 4642b916b0
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 16 14:20:13 2023 +0900
Merge branch 'master' into argon-hide-counter-labels
commit 73eda6c09c259e0f517ffa75a0affb8902ef1fd4
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 16 14:18:49 2023 +0900
Move non-matching default value to argon skin default speficiation instead
commit 39a3313929035bc50e308a5ecee8f568f85dbe76
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 16 14:11:01 2023 +0900
Update tooltip description slightly
commit 4642b916b0b0b2a212a5b72edfc78036d3a3628f
Merge: 7f90db7603 0c0093e641
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 16 13:44:39 2023 +0900
Merge pull request #25468 from peppy/argon-skin-coverage
Add test coverage of accessing skin layout after importing customised default skins
commit dc2d5749651de89bd1e4d5bba615068bfce1ac30
Author: Joseph Madamba <madamba.joehu@outlook.com>
Date: Wed Nov 15 19:41:13 2023 -0800
Fix comment markdown image not showing tooltips
commit 2b19cf6ce4b908880db4854a4f74d30edd7714ac
Author: Joseph Madamba <madamba.joehu@outlook.com>
Date: Wed Nov 15 19:43:25 2023 -0800
Fix comment markdown style regression
commit 7f90db7603714c665ae05cd83f59c61060d8dd2f
Merge: 189fca2eb6 2987c0e802
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 15 19:02:30 2023 +0900
Merge pull request #25472 from bdach/argon-health-folding-in-on-self
Fix argon health bar folding in on itself when too narrow
commit 2987c0e802ec597ab7480c9d3623b423592669bc
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 15 19:01:52 2023 +0900
Add note about enfocing size methodology
commit 0c0093e6413300efa4d3c41e173a0f8f73723a7e
Merge: b118999120 189fca2eb6
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Wed Nov 15 18:30:03 2023 +0900
Merge branch 'master' into argon-skin-coverage
commit b118999120ec13d4632f032429fbc3a26cc43db2
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Wed Nov 15 18:27:08 2023 +0900
Remove unused using directive
commit 189fca2eb6b6327e9efc5074aa0304af940546f9
Merge: 10be233562 7b987266d5
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 15 18:01:24 2023 +0900
Merge pull request #25339 from joshika39/change-clickable-avatars-tooltip-for-usergrid
Add `UserGridPanel` as the `ClickableAvatar` tooltip
commit 7b987266d50db8b3c5668a27625f7635a6eeefbc
Author: Joseph Madamba <madamba.joehu@outlook.com>
Date: Tue Nov 14 16:15:22 2023 -0800
Change behavior of some clickable avatars in line with web
commit deef8998f73850d0e40247fa5854f042967e4687
Author: Joshua Hegedus <josh.hegedus@outlook.com>
Date: Fri Nov 10 11:45:31 2023 +0100
reverted the change
commit aa9deecafe7ad9150d82bfa7015d7e21cf3888b5
Author: Joshua Hegedus <josh.hegedus@outlook.com>
Date: Fri Nov 10 11:37:23 2023 +0100
added missing comment, fixed incorrect visibility
commit 360864fd7b6dac30bda9a2cf4092a316b280427d
Author: cs <cedric.schneider@pmbs.de>
Date: Wed Nov 15 07:45:28 2023 +0100
Hide catmull curve type when possible
commit 520642975bda8de23c51e2b350c637a93115b08c
Author: cs <cedric.schneider@pmbs.de>
Date: Wed Nov 15 07:45:09 2023 +0100
Fix control point hover text and context menu
commit 8cd1f08a923b1b38e7b096e59211c0714089d1e5
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Wed Nov 15 13:33:12 2023 +0900
Fix argon health bar folding in on itself
commit ceeaf5b67c527c787b8d34eb3594207ed9ac14d7
Author: cs <cedric.schneider@pmbs.de>
Date: Wed Nov 15 07:09:33 2023 +0100
CI fixes and small tweaks
commit aac1854d832ff8ad48333ed0afd968ab50dcf712
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 15 14:08:05 2023 +0900
Add test coverage of layout retrievable after importing modified skins
commit a5e1dd8107a8770ab8698cc39a17df2e81847a8b
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 15 14:07:51 2023 +0900
Add test coverage of deserialising a modified Argon skin
commit 62352ce5f3b6ce56c310a83dccd11d9eb15f90fa
Author: Joseph Madamba <madamba.joehu@outlook.com>
Date: Tue Nov 14 20:45:23 2023 -0800
Add ability to toggle labels on argon counter components
commit 87ace7565dfffebbcfb34f48743406a0c68d1065
Author: Joseph Madamba <madamba.joehu@outlook.com>
Date: Tue Nov 14 20:44:33 2023 -0800
Use existing localisation for argon counter component labels
commit 71714f8f6e6bd7d2caf9214ff267c05e550352e7
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Wed Nov 15 13:33:03 2023 +0900
Add back test step for testing out argon health bar width
commit 10be2335621657391be8e2b7a5395738f61f65b6
Merge: 3b619d4c34 159cf41f82
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 15 13:30:36 2023 +0900
Merge pull request #25466 from bdach/argon-health-initial-width
Fix default argon health bar width being zero
commit 159cf41f824546013c22ec454fe1bb33a460f2d1
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Wed Nov 15 12:24:47 2023 +0900
Fix default argon health bar width being zero
Closes #25460.
commit 3b619d4c34ef362344f5dd5ab83dba7fece2e604
Merge: 711bf14c06 2264e1e249
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 15 11:10:59 2023 +0900
Merge pull request #25458 from Joehuu/corner-radius-localisation
commit 2264e1e2493b69d0455f57639e60e3e2e10f7e96
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 15 10:45:01 2023 +0900
Change default value and range of `BoxElement`'s corner radius to match other usages
commit 74fb1b5f81475121af75072367759a241aa4db38
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 15 10:40:59 2023 +0900
Rename property to match expctations
commit 535282ba7d90303058c429c564c9d473afaf8e99
Author: Joseph Madamba <madamba.joehu@outlook.com>
Date: Tue Nov 14 14:13:20 2023 -0800
Use existing localisation for corner radius in `BoxElement`
commit 711bf14c069a7a060d48ea08ec5d58397caa17bc
Merge: 6e0375e3e8 9a7d7dda2a
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Tue Nov 14 23:11:39 2023 +0900
Merge pull request #25443 from peppy/fix-argon-custom-skins
Fix customised argon skins no longer loading due to incorrect resource store specification
commit 6e0375e3e8d2177c6acaf62e6a1973af2be10cc7
Merge: 572ec918d6 83f8f03c7e
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 14 23:10:03 2023 +0900
Merge pull request #25442 from bdach/argon-health-bar-sizing-broken
Fix argon health bar not relative sizing correctly
commit 9a7d7dda2ae564fef11f3e544be339da42abb8d8
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 14 23:04:11 2023 +0900
Update resources
commit a745642f764cf28b37800936186399f459cdd47d
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 14 22:01:56 2023 +0900
Fix customised argon skins no longer loading due to incorrect resource store spec
commit 83f8f03c7e3b173766e9c715bd7869929082600b
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Tue Nov 14 21:46:57 2023 +0900
Fix argon health bar not relative sizing correctly
commit 572ec918d678183b2845bf3f00197e0bc84e31dc
Merge: bb2f38d189 70d2de5669
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 14 17:18:38 2023 +0900
Merge pull request #25432 from bdach/touch-device-fixes
Fix some touch device-related issues
commit 90ec6895d100dea67e282c75a57779ffa87d0f5d
Author: Thomas Müller-Höhne <thomas94@gmx.net>
Date: Tue Nov 14 16:52:45 2023 +0900
Automatic red control point generation & corner threshold
commit 70d2de56695800a2ca14a027d32cf2c36153e8f5
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Tue Nov 14 16:35:16 2023 +0900
Move song select touch detector to solo implementation
It should not run in multiplayer. Even if we wanted to allow touch-only
playlist items at some point, the current behaviour of multiplayer song
selects with respect to touch device mod is currently just broken.
commit 69c2c0e4278d4d419b3ee1ea11f4c8e491514247
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Tue Nov 14 16:30:08 2023 +0900
Fix touch device mod declared valid for multiplayer
Mostly matters for web, so that it doesn't permit creation of playlist
items with touch device inside.
commit fa976a5aa0eeb94dccbcd58b00d51a1c9d7e52df
Author: cs <cedric.schneider@pmbs.de>
Date: Mon Nov 13 08:24:09 2023 +0100
Fix code style/quality issues
commit 8ad8764947835e9ce4070338b6e1ea81016df2b1
Author: Dean Herbert <pe@ppy.sh>
Date: Mon Nov 13 14:06:18 2023 +0900
Update framework
commit e6b4dfba369ee790ee0cee427aa702a935ce341b
Author: Thomas Müller-Höhne <thomas94@gmx.net>
Date: Mon Nov 13 12:49:59 2023 +0900
Fix doubled control point at beginning of drawn slider
commit c24b3543ab271536b2b98c3c4777a174bc0621c1
Author: Thomas Müller-Höhne <thomas94@gmx.net>
Date: Mon Nov 13 12:47:12 2023 +0900
Fix OnDragStart on macOS
commit fab6fc9adb633d82d88afe4c76b1313946032ab4
Author: ratinfx <ratina0@gmail.com>
Date: Sun Nov 12 15:09:15 2023 +0100
Updated comments, renamed method
commit 4e7c40f1d7392376d68989ad5fa26e53430c55c6
Author: ratinfx <ratina0@gmail.com>
Date: Sun Nov 12 14:58:46 2023 +0100
Do Split and Parse before checking HitObjects
commit bb2f38d189b4a1a6ff888f5a74caf90ec60bf746
Merge: 469b9e2546 7d26de723a
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sun Nov 12 20:47:55 2023 +0900
Merge pull request #25411 from peppy/fix-key-counter-sizing-woes
Refactor `KeyCounterDisplay` to use autosize
commit 469b9e2546a0eea247f19bdc9e793170fe7c7b05
Author: Dean Herbert <pe@ppy.sh>
Date: Sun Nov 12 17:28:15 2023 +0900
Increase size and adjust positioning of max combo display in argon skin
commit 7d26de723a789b14f76fbb18b6b4be4b6a7aba93
Merge: 798e677c09 31feeb5ddc
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sun Nov 12 17:23:31 2023 +0900
Merge branch 'master' into fix-key-counter-sizing-woes
commit 31feeb5ddc616bb437c052b2b1680070c9d72563
Author: Dean Herbert <pe@ppy.sh>
Date: Sun Nov 12 17:21:17 2023 +0900
Disable new rider EAP inspection in test class
commit 798e677c092a4ad02e0fe0a81163c14b57ff90d4
Author: Dean Herbert <pe@ppy.sh>
Date: Sun Nov 12 15:12:04 2023 +0900
Refactor `KeyCounterDisplay` to use autosize
A previous attempt at this was unsuccessful due to a partially
off-screen elements not getting the correct size early enough (see
https://github.com/ppy/osu/issues/14793). This can be accounted for by
setting `AlwaysPresent` when visibility is expected.
This fixes [test failures](https://github.com/ppy/osu/actions/runs/6838444698/job/18595535795)
due to the newly added `Width` / `Height` being persisted with
floating-point errors (by not persisting the values in the first place,
via `AutoSize.Both`).
commit b995c96dca4e1163edaa8c67fe878425f6b91399
Merge: ccfdf1ffd6 3e8c89e282
Author: Dean Herbert <pe@ppy.sh>
Date: Sun Nov 12 12:14:26 2023 +0900
Merge pull request #25226 from frenzibyte/gameplay-hud-redesign/counters
commit 3e8c89e282c74874a8c6885228910d70b64d2e95
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sun Nov 12 07:42:41 2023 +0900
Fix one more reference to removed setting
commit c3201d59449a6b281bcbf904871c526dc8873141
Merge: 04a16b3596 ccfdf1ffd6
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sun Nov 12 07:33:50 2023 +0900
Merge branch 'master' into gameplay-hud-redesign/counters
commit ccfdf1ffd6b34aafa91cfce634b63d8fe8556267
Merge: c5bbd5ac8a 50789d2e18
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sun Nov 12 07:31:51 2023 +0900
Merge pull request #25402 from peppy/skin-size-editing
Add support for adjusting size of skin elements
commit c367697559dc8981ce601e44afa45a3ce46a6dc9
Author: ratinfx <ratina0@gmail.com>
Date: Sat Nov 11 16:14:26 2023 +0100
Changed TIME_REGEX to accept everything in the parentheses
- changed osu-web link to the current value
commit 54b8244a18ad3e74d40962be20cab996ba63e90d
Author: cs <cedric.schneider@pmbs.de>
Date: Sat Nov 11 15:02:06 2023 +0100
CI Fixup
commit 04a16b35966daf6a0ce3a42096be7857f2ec15f2
Merge: ea556abad8 c5bbd5ac8a
Author: Dean Herbert <pe@ppy.sh>
Date: Sat Nov 11 22:38:39 2023 +0900
Merge branch 'master' into gameplay-hud-redesign/counters
commit 6ddecfd8062d6b1b0d62a6064d7d0b0b2c8d4760
Author: ratinfx <ratina0@gmail.com>
Date: Sat Nov 11 14:13:06 2023 +0100
Update Test cases
commit 4e1e19728cb8ff9e11f18ab9c0e8635c2cc2ba9a
Author: ratinfx <ratina0@gmail.com>
Date: Sat Nov 11 14:02:42 2023 +0100
Refactor HitObject selection in Composer
commit c5bbd5ac8a7cac4d7fbf2650d54992acdd8cd8e6
Merge: ed59a379f1 b0aa4a4257
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sat Nov 11 21:48:21 2023 +0900
Merge pull request #25408 from peppy/skin-editor-export
Add "export" item to skin editor menu
commit 3f85aa79c5b4402b714da14295b6b796ffa8d6e6
Author: cs <cedric.schneider@pmbs.de>
Date: Sat Nov 11 10:45:22 2023 +0100
Add free-hand drawing of sliders to the editor
commit 926636cc035a17543d987ba9a9ba9c47fa5e7f7f
Author: Thomas Müller-Höhne <thomas94@gmx.net>
Date: Wed Nov 8 19:43:54 2023 +0900
Generalize Bezier curves to BSplines of Nth degree
commit ea556abad802b4cb36ee7ad42b2b7c66b6029f56
Merge: 870e4ce27e 50789d2e18
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sat Nov 11 21:28:29 2023 +0900
Merge branch 'skin-size-editing' into gameplay-hud-redesign/counters
commit 50789d2e18a43dd3b2a2e99ea9487851972f35f9
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sat Nov 11 21:28:04 2023 +0900
Fix song progress bars not sizing vertically properly
commit ee56b4d205f916ea9cf45543c72cce34f53b8a7e
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sat Nov 11 20:55:47 2023 +0900
Use barely better assertion fail message in test
commit 870e4ce27e751d2a7129d5fe396f2f96e74865bc
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sat Nov 11 20:42:45 2023 +0900
Fix argon health display not handling invalidation correctly
commit b0aa4a4257a5f590a1b65613cbf988b7034d7a9e
Author: Dean Herbert <pe@ppy.sh>
Date: Sat Nov 11 20:34:35 2023 +0900
Add "export" item to skin editor menu
commit b7972e3c8485b8a9b3ee4df20bd62b2ed59613a3
Merge: a02aeed50a 8d7539ab70
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sat Nov 11 20:15:49 2023 +0900
Merge branch 'skin-size-editing' into gameplay-hud-redesign/counters
commit ed59a379f16eb093a866422b36e2a80d9200bbfc
Merge: 4b3fd1716a 61d336521d
Author: Dean Herbert <pe@ppy.sh>
Date: Sat Nov 11 20:15:07 2023 +0900
Merge pull request #25407 from peppy/update-framework
Update framework
commit 8d7539ab70ab1a3cece963afa36802ddd7518682
Merge: b247b94ecb 4b3fd1716a
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sat Nov 11 19:56:09 2023 +0900
Merge branch 'master' into skin-size-editing
commit 4b3fd1716a4850ce54b31fdc87a81cc80f26f149
Merge: 1c63f1f89d 2428a97d44
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sat Nov 11 19:55:04 2023 +0900
Merge pull request #25406 from bdach/skin-editor-bad
Fix skin editor not clearing undo history on skin change
commit 61d336521da4adc3c8dcc6bacc20a7f23a306d34
Author: Dean Herbert <pe@ppy.sh>
Date: Sat Nov 11 19:48:56 2023 +0900
Update framework
commit b247b94ecbdb5405de16ba489ef7a62b36cd7656
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sat Nov 11 19:15:20 2023 +0900
Revert test changes
They were broken because `SerialisedDrawableInfo` is a reference type
and as such equality checks will use reference equality rather than
member equality.
commit 2428a97d449b5e5f51ea2f9c8805c32521301a07
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sat Nov 11 17:02:21 2023 +0900
Fix editor not clearing undo history on skin change
commit 21e1d68b15960c448d9876baaec51776febde22c
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Sat Nov 11 15:52:24 2023 +0900
Remove unused using directive
commit 96da7a07bbd79bc67cbc58196bb38cd6c835c83a
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Sat Nov 11 02:57:29 2023 +0300
Add detailed explaination on existence of `ScheduleUntilTransitionEnd`
commit bb912bc6161a8785f105e3da29f7e95f83261249
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Sat Nov 11 02:57:17 2023 +0300
Avoid spinning another load thread on initial storyboard load
commit 080f13e34d0f5f60381d813edfd590aa2b466194
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Sat Nov 11 02:56:16 2023 +0300
Schedule outside of `UnloadStoryboard` and fix disposal happening on update thread
commit 2e48569982039c9c1e6cb722190a6669ea09aee7
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 20:00:51 2023 +0900
Improve test comparison logic
Doesn't really help that much with nunit output,
but at least you can breakpoint and see the json kinda.
commit 57cd5194ce06b16e03dc0dea32a0e81da80b1029
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 20:00:20 2023 +0900
Flip comparison to allow non-composite drawables to still get resized
commit b7acbde719744a3aac166c676b792e9d87699612
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 19:12:26 2023 +0900
Only store width/height of serialised drawable if it isn't automatically computed
commit b6dcd7d55f0d421d85e2e97d00ae5704d1fb5487
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 18:48:45 2023 +0900
Fix tests so that they actually assert something
commit fbf94214a536a5b5aa7246d2ee34ee5ecacf8fb1
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 18:36:09 2023 +0900
Fully delegate tooltip show/hide logic
commit ec2200d54fff1cf823355571c2a3c827c3a19ca8
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 18:26:08 2023 +0900
Remove another reference to bar length
commit 26eae0bdeeed6670fc3a47b81abdc75afceda434
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 18:25:39 2023 +0900
Remove unused using directive
commit 43a4b34295471a2a4c0103aa9383ef75cbb8dc56
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 18:20:14 2023 +0900
Fix typo
commit c522a703eb4c7122863867124ac309a77b950dd0
Merge: 374e13b496 1c63f1f89d
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 18:19:27 2023 +0900
Merge branch 'master' into skin-size-editing
commit 374e13b496dc3780e03f2c9f76a850ab0a8050e5
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 18:18:45 2023 +0900
Remove argon health display bar length setting
It is no longer needed.
Intentionally not doing backwards migration to simplify things; users
can fix their skins.
commit 2c1f304f3b4faaa645edb3c138b915ad351c9fa0
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 18:13:36 2023 +0900
Fix test failures due to fluctuations in needlessly-serialised automatic sizings
commit 1c63f1f89dadef715138cf3979c17110db3fb9bf
Merge: 74ccb0873e b7938e78a0
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 18:01:40 2023 +0900
Merge pull request #25348 from bdach/less-basic-touchscreen-detection
Implement basic touchscreen detection
commit 36d0bae42dfe95481b3e20751d8f7032b925e9df
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 17:57:16 2023 +0900
Restore mention of dependency on another ctor param
commit 35e11c7c63b83122a45f5f9820aa6909ffb892bd
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 17:51:30 2023 +0900
Rename diagonal scale variable and update xmldoc
commit d0f1326a63da2187c80c7429cf386bfb3856c8c5
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 17:54:48 2023 +0900
Fix formatting
commit f25489cc7be71426891f50046b70aefdc24578de
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 17:53:56 2023 +0900
Check X/Y sizing available separately to fix weird edge cases
commit 46a219e01010e32827f3772aae77fece7de8bccf
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 17:53:02 2023 +0900
Add comment explaining `AutoSize` change in `LegacySongProgress`
commit 74ccb0873edcbaa7af5a26973c30bc17e9ec3cf0
Merge: 7c4e9506da 93ff82bc80
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 16:59:17 2023 +0900
Merge pull request #25403 from smoogipoo/attempt-fix-diffcalc-quotes
Attempt to support quotes in handling of GH comment body
commit a02aeed50af48f580a1c5d7fbb8a792f2a652f1a
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 16:50:41 2023 +0900
Adjust combo animation slightly
commit 67312a2db922287fef12c53f00be99b2aa79df8d
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 16:43:47 2023 +0900
Remove `ArgonScoreWedge` and use `ArgonWedgePiece` directly
commit b4ec62473e0e79638b439a9ffd677871014841b3
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 16:37:07 2023 +0900
Remove width/height bindables from `ArgonWedgePiece`
commit fa5921862f99e6ed4a9757938ad77a8bd9d066ed
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 16:19:42 2023 +0900
Update deserialising test
commit b7938e78a0dc05f6847323058ef58f235e67324f
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 16:30:21 2023 +0900
Make sure test is in a break
...because apparently it may take a while to update the flag.
commit 7c4e9506dad02f7e4282ac478f765d844e954654
Merge: a8cf105beb 1b08f317fb
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 16:25:01 2023 +0900
Merge pull request #25399 from Susko3/mobile-touch-settings
Show touch input settings on mobile
commit 7db14baed74277383e4ac567577bb08b3b2aeea5
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 16:13:45 2023 +0900
Update resources
commit 60df2722ab7d72e040b176d0d756493c6c2daf4e
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 16:04:28 2023 +0900
Rename `RoundedLine` to `BoxElement` and make more generically useful
commit 8690b0876928570e5df1d25a1568db6ec703ee05
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 16:08:45 2023 +0900
Fix compose select box test failures
commit 1818a84034c57f76335e06371b6a68296b0126f4
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 15:52:02 2023 +0900
Rewrite tests to not rely on realtime clock
Definitely faster, hopefully more reliable too.
commit 4f90ac15fad7df54047abd01b6f88b6e28310277
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 15:39:17 2023 +0900
Reduce the default wireframe opacity a bit
commit 7e0b41219cd916931bd18d32f87705624b4e723b
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 15:26:37 2023 +0900
Change animation to only affect number portion, add miss animation
commit e861681cd4a081b3cc557df725cb0d2737096ebc
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 15:06:19 2023 +0900
Adjust argon rolling easings
commit 7c3a626f4b2a1706cfc46295770b8673b374aee4
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 15:06:07 2023 +0900
Add basic animation for combo counter
commit 6c1d48dfaf0e4f06489b22c32b437a2d18d5250a
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 14:51:14 2023 +0900
Remove unused function
commit 99d9db5b76ba5292398201039e75fcb0a9bcc1d7
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 14:03:24 2023 +0900
Use a better default size for line
commit f31c1c9c7941db573a9516710e42e53946947e25
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 12:58:07 2023 +0900
Rename and move skinnable line component to a more commomn place
commit a8cf105beb7d8f746c4df2957d448dabc86044d2
Merge: 1a8636638d 44c0442f4f
Author: Dan Balasescu <smoogipoo@smgi.me>
Date: Fri Nov 10 15:07:05 2023 +0900
Merge pull request #25342 from peppy/slider-combo-matching-2
Fix osu! (slider) combo not matching expectations when classic mod is disabled
commit 93ff82bc80c8bc06bc78149fd49584396ca982bd
Author: Dan Balasescu <smoogipoo@smgi.me>
Date: Fri Nov 10 14:52:03 2023 +0900
Attempt to support quotes in handling of GH comment body
commit 175dae49c623bfa8632608e204cac168d0b9723a
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 14:43:51 2023 +0900
Reset scale per axis
commit 0add035c674d59bd36ef129d474a76550e3ced92
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 14:31:02 2023 +0900
Disable resizing of `LegacySongProgress`
Because it looks bad.
commit fb361a4e0a8152bb35fe16cdc98bf06993f64a67
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 14:25:55 2023 +0900
Reset size along with scale for relative items
commit ec3b6e47fb7c6b302e633132362bfe54873a58a6
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 14:17:11 2023 +0900
Change selection handling to adjust `Size` instead of `Scale` for edge nodes
commit b0c5b3cb1097861506b11862b996b91afe7a384a
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 14:15:42 2023 +0900
Add `Size` to serialised components of a `SerialisedDrawableInfo`
commit 44c0442f4fc7f29f94ea1acad609ab8a676788d0
Author: Dan Balasescu <smoogipoo@smgi.me>
Date: Fri Nov 10 14:00:34 2023 +0900
Adjust comment on Slider's judgement
commit 1a8636638dd8a7e8a7f9584aa5fa483e21305981
Merge: 8d47c64325 12a148d108
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Fri Nov 10 05:01:21 2023 +0100
Merge pull request #25385 from peppy/update-squirrel
Update squirrel to latest release
commit f13648418b82f7158a733588e8caf4f094efc1ec
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 12:10:52 2023 +0900
Update `HitResultTest` to be more conformant to original expectations
commit fb02c317507b7c58770bdd52984eb6a0f91f9b53
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 12:09:48 2023 +0900
Fix typo in assert step
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
commit e0a5ec5352d0edf5d73513e203cdeda51624a302
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 12:09:16 2023 +0900
Revert incorrect classic mod test assertions
commit 7fc2050f7227424b7e734260126146c48e99358e
Author: Dean Herbert <pe@ppy.sh>
Date: Fri Nov 10 11:52:34 2023 +0900
Rename variables and mak seconary tooltip type work again
commit d3af3c615f01fafb22dc4d0dbeeeb417c73a72c0
Merge: 6f5d905ce7 8d47c64325
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Fri Nov 10 01:04:03 2023 +0300
Merge branch 'master' into gameplay-hud-redesign/counters
commit 6f5d905ce766da9b2e3753585a41298118e9c6b9
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Fri Nov 10 00:34:29 2023 +0300
Update argon accuracy counter design
commit 59998b507acf084cc8d4ffbe85e16d1f3fab9229
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Thu Nov 9 23:23:49 2023 +0300
Hide background sprite when storyboard finishes loading
commit e9471589697083d8ea2214b299aca226085e7de9
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Thu Nov 9 23:03:01 2023 +0300
Remove fade out transition
Unnecessary addition from this PR, makes the background fade to ugly black during transition between screens.
commit cc9aeb53079f6f00af307fb0544e0335d9eebcc8
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Thu Nov 9 22:57:12 2023 +0300
Add test coverage
commit 768a31b2f5ec05907f2e1cf18d4bb3f63ae83da1
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Thu Nov 9 22:56:48 2023 +0300
Fix background crash on a beatmap with no storyboard
commit bd8409219f079bcdd922ae2169d676608e512364
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Wed Nov 8 06:37:29 2023 +0300
Unload beatmap storyboard background when no longer present
commit d4722a398892a18f14e868ff471e9132004da8fd
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Thu Nov 9 17:20:05 2023 +0300
Add failing test case
commit 1b08f317fbd1fac55276dc05c29b0339667f2871
Author: Susko3 <Susko3@protonmail.com>
Date: Thu Nov 9 15:12:24 2023 +0100
Show touch input settings on iOS
This does not cover android since `TouchHandler` is SDL-based.
commit 0c4c9aa4b515840611b3b39017ff73d04a3ecf1b
Author: Susko3 <Susko3@protonmail.com>
Date: Thu Nov 9 14:37:10 2023 +0100
Show touch taps setting in player loader on mobile platforms
commit 51cf85a9ab3806fe9294d33b24c52165a08aed6b
Author: Susko3 <Susko3@protonmail.com>
Date: Thu Nov 9 13:22:49 2023 +0100
Add touch input settings to android
Also updates touch settings so the touch handler can't be disabled on mobile.
commit 8d47c64325ead06322d13cbeee82c46b23b262e8
Merge: 5180fa669b 4fa158e0d8
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 9 14:39:01 2023 +0100
Merge pull request #25398 from peppy/tournament-split-players-better
Split tournament player lists more equally
commit 615d8384abcc3c412a831a70a73ed0f6c6173467
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 9 22:27:29 2023 +0900
Refactor everythign back to sanity
commit edef31f426f8568afc3abf53b7611e525308c1d0
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 9 21:48:41 2023 +0900
Correctly propagate classic behaviour flag to tail
commit 1ae3265f925911c3a1f7f640805765b68dc5d335
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 9 21:24:30 2023 +0900
Update tests in line with new behaviour
commit 4fa158e0d832f44cddefac1b0dd7b94f879e3993
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 9 21:35:37 2023 +0900
Split tournament player lists more equally
commit 5180fa669ba55a5d22c6aca197ee5b315437acb7
Merge: 67dc3aa5b7 92e4a8666d
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 9 13:34:29 2023 +0100
Merge pull request #25343 from peppy/spinner-max-sample
Continue to play spinner bonus sounds when MAX display occurs
commit 4900a91c60fda24f76aeba4d2d2bf42cc1929e2d
Author: Joshua Hegedus <josh.hegedus@outlook.com>
Date: Thu Nov 9 13:27:09 2023 +0100
fixed static analysis problems and finished the implementation
commit ccb9ff826a87dbafbbeb0a0a572a404bc88c7e88
Author: Joshua Hegedus <josh.hegedus@outlook.com>
Date: Thu Nov 9 13:09:59 2023 +0100
fixed tests
commit 92043f45a47b89a22695089d93aeb87c12553c58
Merge: d3c5988bf1 67dc3aa5b7
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 9 18:45:37 2023 +0900
Merge branch 'master' into slider-combo-matching-2
commit 02966bc02f61c776dc7333c7d0531338c7716927
Merge: f897c21b3f 67dc3aa5b7
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 9 18:19:23 2023 +0900
Merge branch 'master' into change-clickable-avatars-tooltip-for-usergrid
commit 67dc3aa5b7efa4a722c9d51a7da7e16ceaed6d54
Merge: 67de1b34bd c00a1d948a
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 9 18:19:02 2023 +0900
Merge pull request #25366 from Susko3/better-touch-settings
Add "disable taps during gameplay" to touch input settings and related UI
commit 67de1b34bd2ea9ec8c199e1adfbff16094aeacb4
Merge: 5ac285ed2f e3e752b912
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 9 18:03:47 2023 +0900
Merge pull request #25395 from nekodex/buttonsystem-updates
SFX improvements for `ButtonSystem`/`MainMenu`
commit e3e752b912ba0b14f9d2d2a96bc1695e65eb94cd
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 9 17:56:58 2023 +0900
Update resources
commit 63a0ea54109c93984501b66435febf676663cab4
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 9 17:50:57 2023 +0900
Fix `PlayerTouchInputDetector` applying touch device mod when other inactive mods present
commit 5d5c803cf6fc97c044551a8bd7d3d11f0db8f41c
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 9 17:48:43 2023 +0900
Add failing test case for touch device application during gameplay with incompatible mods active
commit 13b599b9b64acb2fa5744e580f8df8d9fcff9fea
Merge: 39ad91feea 5ac285ed2f
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Thu Nov 9 17:36:48 2023 +0900
Merge branch 'master' into less-basic-touchscreen-detection
commit 8a47f05b1615e126c9841b52dd63576a5b1b521a
Author: Jamie Taylor <me@nekodex.net>
Date: Thu Nov 9 14:01:33 2023 +0900
Always play 'swoosh' sample when transitioning back to logo
commit 12a148d1084b1a6f11525ff16c223ecb6ddd6927
Author: Dean Herbert <pe@ppy.sh>
Date: Thu Nov 9 12:26:41 2023 +0900
Use new initialisation structure for github sourced update manager
commit f69c2ea39b46fff223c8372e6dd1d2a6b2da5bce
Author: Jamie Taylor <me@nekodex.net>
Date: Wed Nov 8 22:18:33 2023 +0900
Implement sample choking/muting for `ButtonSystem` samples
commit f0a1df06aced3051a93684588a6f21a0bf0fafd0
Author: Jamie Taylor <me@nekodex.net>
Date: Wed Nov 8 22:13:35 2023 +0900
Add 'swoosh' samples to accentuate `MainMenu` animations
commit 17aa079cb1cd1ee7ae22942aa582507c37037c4d
Author: Jamie Taylor <me@nekodex.net>
Date: Wed Nov 8 22:08:05 2023 +0900
Use new tiered 'back' samples
commit fc1a0cf645b345c1b2b0727313a4f11b207a3268
Author: Jamie Taylor <me@nekodex.net>
Date: Thu Oct 19 16:20:10 2023 +0900
Update `ButtonSystem` to use new sample names
commit 5ac285ed2f915bb828c9e0762ad5547cfe506e3f
Merge: 626cfae3fe 38d16f620c
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 8 18:56:00 2023 +0900
Merge pull request #25380 from frenzibyte/fix-create-difficulty-crash
Fix editor crash when creating a new difficulty in a non-existent beatmap
commit 626cfae3feb9dd70ab347b44f488c80a836681b4
Merge: 9df8fc14e7 38847c3ac5
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 8 17:24:37 2023 +0900
Merge pull request #25386 from EVAST9919/bar-graph-smooth
Ensure `BarGraph`'s draw quad is thick enough
commit 38847c3ac5383c9fb69b7bf0b38aa8ea36b23b39
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 8 17:23:01 2023 +0900
Change test to move only on a toggle step
commit 6c6baab1156f64388e5fcea3ad712cc7e24bb463
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 8 16:41:30 2023 +0900
Reword comment to explain why
commit 9df8fc14e708b6024ab66f9e9c1fc1afabf9451c
Merge: 34219c1103 c8d276281a
Author: Dean Herbert <pe@ppy.sh>
Date: Wed Nov 8 12:46:59 2023 +0900
Merge pull request #25388 from Joehuu/kudosu-rankings
Add ability to view kudosu rankings
commit c8d276281ada839a37ab6eb484c36b9b7772a0d1
Author: Joseph Madamba <madamba.joehu@outlook.com>
Date: Tue Nov 7 15:49:11 2023 -0800
Fix flags not showing on kudosu rankings
The `country` attribute is optional and not included in the kudosu rankings response so use `country_code` instead.
commit 387de7ec244f1e5c7381693b6dad96a64630ce1f
Author: Joseph Madamba <madamba.joehu@outlook.com>
Date: Tue Nov 7 15:53:41 2023 -0800
Add ability to view kudosu rankings
commit 2ef17c56b115c3df3d7a539f7494ad568b3a3ddf
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Wed Nov 8 02:13:35 2023 +0300
Remove unused local
commit d0fea381b18b5f19450f4d93951e0aed152a85c8
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Wed Nov 8 02:13:16 2023 +0300
Update skin deserialisation archives
commit 18c71c95ccc565255676140486f30a4ed6d3b04f
Merge: 07b7e13633 34219c1103
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Wed Nov 8 02:12:37 2023 +0300
Merge branch 'master' into gameplay-hud-redesign/counters
commit 07b7e13633862e85522f0c1778c8dc06ee62724d
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Wed Nov 8 02:07:24 2023 +0300
Place health display in front of the score wedge
commit 4de5454538b0dff1b8b4a020a7f12fcb294ccc06
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Wed Nov 8 02:06:51 2023 +0300
Bring back left-side line next to health display
Makes the score counter not look weird when it reaches 8 digits
commit fdc714a248d1a9283649d12a11a14e7763bfa1dc
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Wed Nov 8 02:05:19 2023 +0300
Support percentages and ignore dot characters in wireframes part
commit d30bac3f49af02f2473e9c1a71aacbdb8f42dd4e
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Wed Nov 8 01:49:13 2023 +0300
Move "required display digits" feature to reside in argon score counter
commit e6d3085353886da1a196f6d0354eae86ba9469fa
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Wed Nov 8 01:48:21 2023 +0300
Update accuracy counter design
commit cbea2db4bef9322b8dcbe9619d95cb918dcc3b55
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Tue Nov 7 02:03:16 2023 +0300
Support absolute-sized health bar and use it for default layout
commit b092b0093affc97453d4f14be7b7a68005d5ae31
Author: Andrei Zavatski <megaman9919@gmail.com>
Date: Mon Nov 6 21:13:36 2023 +0300
Make sure bar draw quad is thick enough
commit c00a1d948a94b871c4b50099d3f5924d142714c4
Merge: 3e257f1e6c 34219c1103
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 7 23:21:59 2023 +0900
Merge branch 'master' into better-touch-settings
commit 3e257f1e6c02795c6bbb6bf08f542707e8e6e827
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 7 23:21:51 2023 +0900
Remove unused using statements
commit 34219c11030239aa1674981c22ab397620b090a6
Merge: ed02335e3e 7bedf7cf16
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 7 21:57:00 2023 +0900
Merge pull request #25364 from frenzibyte/fix-resume-cursor-following-settings
Fix resume cursor following gameplay cursor scale setting
commit 02d9f005d09df3bd755a337a7d63c3ef4353d8b0
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 7 21:27:02 2023 +0900
Update squirrel to latest release
Quite a few fixes since our last update. See https://github.com/clowd/Clowd.Squirrel/releases.
Of special note is [a fix for incomplete updates](https://github.com/clowd/Clowd.Squirrel/issues/182)
which I believe we've seen cause issues in the wild before.
commit 00268d0ccce3691e682f7ae2ff08cb6a9a1f88f8
Author: Susko3 <Susko3@protonmail.com>
Date: Tue Nov 7 13:09:30 2023 +0100
Remove unused using
commit 7bedf7cf165e1a9a125eb74af636dca957e8fc0d
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 7 21:08:49 2023 +0900
Move static method to end of file
commit fcd73e62d2f98472e66524913c5f58fa2499d4f2
Author: Susko3 <Susko3@protonmail.com>
Date: Tue Nov 7 13:06:14 2023 +0100
Remove mobile specific changes
Will be added back in a separate PR
commit 81caa854e6a7ba3251658f1cd174bf6bad62b1ea
Author: ratinfx <ratina0@gmail.com>
Date: Tue Nov 7 13:02:46 2023 +0100
Separate Test cases by relevant rulesets
commit 544d5d1d86416a179de9c6badd7833a8e53ca518
Author: ratinfx <ratina0@gmail.com>
Date: Tue Nov 7 12:23:22 2023 +0100
Forgot a clock.Stop call
commit 38c9a98e67e421a965d5979425ace752517e63e2
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 7 10:52:48 2023 +0900
Add failing test coverage
commit bdbeb2bce4286122584e0c7f9dff61bdc5d57ca1
Author: ratinfx <ratina0@gmail.com>
Date: Tue Nov 7 11:11:32 2023 +0100
Renamed CollectionChanged event handler
commit aa87e0a44d469bbdfb9abe9bca13ea0323eda774
Author: ratinfx <ratina0@gmail.com>
Date: Tue Nov 7 01:36:58 2023 +0100
HitObject Selection logic and separation for gamemodes
+ moved time_regex into EditorTimestampParser
commit 44f127c8a86c9fa381118571c5af5e26f8cf141d
Author: ratinfx <ratina0@gmail.com>
Date: Tue Nov 7 01:02:45 2023 +0100
Renamed method and made private
commit 0834b79cc7fcb78873e381754f709deba0be4693
Author: ratinfx <ratina0@gmail.com>
Date: Tue Nov 7 00:56:24 2023 +0100
Renamed method and moved Notifications inside
commit 8e8a88cfaf4852d4e80611677cb5948806096704
Author: ratinfx <ratina0@gmail.com>
Date: Tue Nov 7 00:54:15 2023 +0100
Removed nullable line from Test
commit 7385c3c97bb48b507127dd8709d658788adbaf78
Author: Susko3 <Susko3@protonmail.com>
Date: Tue Nov 7 00:17:15 2023 +0100
Move `InputSettings` children creation code to BDL
- Avoids now obsolete variable name
- Makes changing to touch detection easier (access to session statics in BDL)
commit 05d941871860fc94db9d92d722d44eb4f190766a
Author: Susko3 <Susko3@protonmail.com>
Date: Tue Nov 7 00:13:46 2023 +0100
Rename setting to `TouchDisableGameplayTaps` for better visibility when searching
commit 0dbba13686388559a25558ebbd4a4fd17c858e1d
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Tue Nov 7 01:59:00 2023 +0300
Split argon score sprite text and update combo counter design
commit 7c1c62ba8aef898bddaa6c07124a1053251bdf8a
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Tue Nov 7 01:58:26 2023 +0300
Remove argon combo wedge and update combo counter position
commit ce36884ef05dbe1664e93ef9285abb43b0849067
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Tue Nov 7 00:54:34 2023 +0300
Make score wireframes display up to required digits count
commit 4c7db4c2625483d557f1e4b6964579adcb7a0060
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Tue Nov 7 00:49:22 2023 +0300
Make score counter right-aligned
commit 754e05213c452f1f1ddc1c3485ae9e4270b23979
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Tue Nov 7 00:53:20 2023 +0300
Update argon score wedge design
commit 01e59d134a9b8436404a1c6de4bc5cb07332dfe8
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Tue Nov 7 00:48:51 2023 +0300
Adjust health bar settings on default components initialiser to match new layout
commit a4ac50cf86f8cbd148eedf75b765c65ad34301b6
Author: Susko3 <Susko3@protonmail.com>
Date: Mon Nov 6 21:10:04 2023 +0100
Revert "Rename popup/binding string to `Toggle gameplay clicks/taps`"
This reverts commit 0d8bfedf5d3693809e76471b9feb47ebf140e40b.
commit ed02335e3eb802c1865a653eac0af1b1050f3121
Merge: 9f6304b9ab a136f272cf
Author: Dean Herbert <pe@ppy.sh>
Date: Tue Nov 7 05:08:47 2023 +0900
Merge pull request #25377 from bdach/system-mod-better-colours
commit f8b5ecc92a2e303a87a23c218a24c103881cb8c5
Author: Susko3 <Susko3@protonmail.com>
Date: Mon Nov 6 21:07:15 2023 +0100
Update UI to use the new setting
commit ea357bafddd9970fb2c7f06686e1604b6caca76f
Author: Susko3 <Susko3@protonmail.com>
Date: Mon Nov 6 20:53:22 2023 +0100
Fix tests by using the correct setting for touch input
commit c1967a5cbb640cf296832efec00b392922c398c9
Author: Susko3 <Susko3@protonmail.com>
Date: Mon Nov 6 20:43:24 2023 +0100
Make tests fail
commit d6e7145e1c676ff45eb820f42375500cba43c3a1
Author: Susko3 <Susko3@protonmail.com>
Date: Mon Nov 6 20:42:40 2023 +0100
Add new setting for GameplayDisableTaps
commit 38d16f620cdef1ab457ce2b82c5c9d1d91113761
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Mon Nov 6 21:55:00 2023 +0300
Alter test case to comply with new behaviour
commit b2749943e27ae31fb392b1bbad918cbd9432412e
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Mon Nov 6 21:52:46 2023 +0300
Display "required save" popup when creating another difficulty on a new beatmap
commit 944fee56f8d8e61895882a5c55c9d6ff0e6c637e
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Mon Nov 6 21:48:47 2023 +0300
Add failing test case
commit 9d10d93085cd3cde44d63836911bc607d5618901
Author: Andrei Zavatski <megaman9919@gmail.com>
Date: Mon Nov 6 20:45:52 2023 +0300
Adjust test scene to see graph flickering
commit a136f272cf78ec3572bc13bdcf0de47b74789a73
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 16:40:57 2023 +0100
Just use yellow for system mods
commit 073249dafb3605a36bb8482f73f2dac1b7733b9f
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Mon Nov 6 18:35:46 2023 +0300
Allow tinkering with cursor-related settings in resume overlay test scene
commit e12ee29a942279becf7ca4fd3816af1787b3fce8
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Mon Nov 6 18:35:30 2023 +0300
Update existing test coverage
commit 75fbbb35ad2f88524670a19312dcb43569db8190
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Mon Nov 6 18:28:51 2023 +0300
Move cursor scale application within `OsuCursor`
Doing so takes down two birds with one stone.
1. `ResumeOverlay` having to manually apply cursor scale to its "resume
cursor".
2. Resume cursor input handling scaling up with the gameplay setting. Now, only the sprite itself gets scaled.
commit 915feeffb05389da36e9eb4e1c75f962202b3703
Author: Salman Ahmed <frenzibyte@gmail.com>
Date: Mon Nov 6 17:37:25 2023 +0300
Revert gameplay cursor scale changes
commit f897c21b3f5b57b5892f25cef3644aabf82d7c43
Author: Joshua Hegedus <josh.hegedus@outlook.com>
Date: Mon Nov 6 15:25:12 2023 +0100
partial change
commit a01f6187f4738f85376cb820315d95d8c4545e4c
Author: Joshua Hegedus <josh.hegedus@outlook.com>
Date: Mon Nov 6 14:52:06 2023 +0100
testing the tooltip
commit 9f6304b9ab612bcdb24c5eb33101f818b9d60909
Merge: 408ae84111 51c891e2e4
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 12:40:11 2023 +0100
Merge pull request #25376 from peppy/verify-screen-refresh-on-enter
Automatically refresh the verify screen's issue list on re-entering it
commit 4bc36a6c90dfd051cd6202be7e4fec48c1b05080
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 12:18:02 2023 +0100
Fix unused variable
commit 034f53da4b1d79220d8af95055a203076ab88c87
Author: Joshua Hegedus <josh.hegedus@outlook.com>
Date: Mon Nov 6 11:54:57 2023 +0100
added isEnabled to tooltip
commit 39ad91feea58e0a91e95b3a2be0889ff98be4ce6
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 11:50:04 2023 +0100
Make debug input toggle post notifications
commit 6deac9a5a45319d1536a9dc223a4efb07324a63c
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 11:24:56 2023 +0100
Use better colours for system mods
commit 51c891e2e4ff17432a01bf4f9ee75ad8c1498883
Author: Dean Herbert <pe@ppy.sh>
Date: Mon Nov 6 19:34:34 2023 +0900
Automatically refresh the verify screen's issue list on re-entering it
Addresses https://github.com/ppy/osu/discussions/25365.
commit 718492a0b7d9c38b32102095c84393fbe5a792d9
Author: Joshua Hegedus <josh.hegedus@outlook.com>
Date: Mon Nov 6 11:29:15 2023 +0100
fixed DRY
commit 682668ccf0f73bdbb98b800afcaff983399d391d
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 10:54:32 2023 +0100
Remove touch device toasts entirely
commit 92e4a8666def6e4bcc66d008ca0d206ca6c6cbd8
Author: Dean Herbert <pe@ppy.sh>
Date: Mon Nov 6 18:43:47 2023 +0900
Add `spinnerbonus-max` support and fallback to `spinnerbonus`
commit b219a371a93d82c3638df3b47f51e85d20f1fb94
Author: Dean Herbert <pe@ppy.sh>
Date: Mon Nov 6 18:29:51 2023 +0900
Move sample playback logic local to avoid edge case with no bonus ticks
Can't see a better way of doing this.
commit 86cf0a36cfb842cf97f074988a28c9958e9b0b81
Author: Dean Herbert <pe@ppy.sh>
Date: Mon Nov 6 18:16:31 2023 +0900
Add test coverage of spinner with no bonus ticks
commit aa6f14b0247f2fe0768379b9a1ae03f75827ba86
Author: Dean Herbert <pe@ppy.sh>
Date: Mon Nov 6 18:16:04 2023 +0900
Fix spinner test hitting assertion when spinning too fast
commit 204cd541e2b8876089c619abd94e97baafb97b8b
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 10:14:56 2023 +0100
Use placeholder mod icon for touch device
commit 97fee6143c7b81d169452396a490b8293b521527
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 10:08:19 2023 +0100
Rename touch "input handlers" to detectors
commit 408ae841110854b17c963beb67c7aa68e9f55555
Merge: 41cd9a4db6 1f0b914251
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 09:38:48 2023 +0100
Merge pull request #25375 from peppy/reset-rotation-skin-editor
Add skin editor dropdown items to reset rotation and scale
commit 41cd9a4db615290f557c664b9151c1c48ef64667
Merge: 5ef8500d2a 69d6feb5a8
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 09:34:11 2023 +0100
Merge pull request #25374 from peppy/add-skinnable-player-name
Add player name skin component
commit e2928cc6b96f816320f238e5f653bd75c5ed9ca3
Author: Dean Herbert <pe@ppy.sh>
Date: Mon Nov 6 17:32:39 2023 +0900
Fix incorrect assertion check targets (and flip assertion for miss case)
commit 4a70f2435c574b82829a5d2508ae29f7d2e3a2fb
Author: Joshua Hegedus <josh.hegedus@outlook.com>
Date: Mon Nov 6 09:22:50 2023 +0100
fixed showUsernameTooltip
commit 5ef8500d2ac66aaa647833d2fe07faa8b9315fcb
Merge: bc9cdb4ce0 0915ac8891
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 09:19:49 2023 +0100
Merge pull request #25349 from Joehuu/argon-key-counter-upright
Keep `ArgonKeyCounterDisplay` text upright
commit b62811633f07820848ec960e228989f02e30f68c
Author: Dean Herbert <pe@ppy.sh>
Date: Mon Nov 6 17:17:19 2023 +0900
Add test coverage of touching and missing not enabled touch mod
commit 69d6feb5a8b9137aaf74956945b897d7741fe3a3
Author: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Date: Mon Nov 6 08:51:31 2023 +0100
Add test coverage for player name skin component
commit b45d8c785cd662796c6098f72aadf589b99161e4
Author: Joshua Hegedus <josh.hegedus@outlook.com>
Date: Mon Nov 6 08:38:34 2023 +0100
fixed review findings
commit 0915ac8891f1a5036a325d95b870d29c0daeb733
Author: Dean Herbert <pe@ppy.sh>
Date: Mon Nov 6 16:32:12 2023 +0900
Use left aligned text for non-rotate key counter
commit 1f0b914251bc61d82bf9e3db207e75399a600806
Author: Dean Herbert <pe@ppy.sh>
Date: Mon Nov 6 16:18:33 2023 +0900
Add skin editor dropd…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supposed to address multiplayer errors as seen on sentry: https://sentry.ppy.sh/organizations/ppy/issues/28940/.
69c2c0e: Fix touch device mod declared valid for multiplayer
Mostly matters for web, so that it doesn't permit creation of playlist items with touch device inside.
70d2de5: Move song select touch detector to solo implementation
It should not run in multiplayer. Even if we wanted to allow touch-only playlist items at some point, the current behaviour of multiplayer song selects with respect to touch device mod is currently just broken.