Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some touch device-related issues #25432

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Fix some touch device-related issues #25432

merged 2 commits into from
Nov 14, 2023

Commits on Nov 14, 2023

  1. Fix touch device mod declared valid for multiplayer 

    Mostly matters for web, so that it doesn't permit creation of playlist
items with touch device inside.
    @bdach
    bdach committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    69c2c0e View commit details
    Browse the repository at this point in the history

  2. Move song select touch detector to solo implementation 

    It should not run in multiplayer. Even if we wanted to allow touch-only
playlist items at some point, the current behaviour of multiplayer song
selects with respect to touch device mod is currently just broken.
    @bdach
    bdach committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    70d2de5 View commit details
    Browse the repository at this point in the history