Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drag bar on chat overlay to better signal resize-ability #25567

Merged
merged 8 commits into from Nov 27, 2023

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Nov 24, 2023

As proposed in #25499.


CleanShot.2023-11-24.at.07.40.52.mp4

Copy link
Member

@Joehuu Joehuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should always show on mobile/touch-capable devices (similar UX problem as #18642).

@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 24, 2023
@peppy
Copy link
Sponsor Member Author

peppy commented Nov 24, 2023

I think it should always show on mobile/touch-capable devices (similar UX problem as #18642).

Have changed this.

@bdach bdach added the next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! label Nov 27, 2023
@bdach bdach enabled auto-merge November 27, 2023 01:47
@bdach bdach merged commit d50aac8 into ppy:master Nov 27, 2023
11 checks passed
@peppy peppy deleted the chat-drag-improvements branch November 28, 2023 09:08
@tovc
Copy link

tovc commented Nov 30, 2023

Having the drag bar only visible while hovering over the chat head bar doesn't really help much; Most players will only occasionally mouse over the chat bar, and if they're lucky, they'll notice the relatively minimal change in colour on a small part of the chat bar. The bar should always be visible, even outside of touch devices, and/or there should be a persistent hint

Additionally, the chat bar is now only draggable on the small region where the bar is visible, which also doesn't feel great

2023-11-30.20-29-26.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/L type:cosmetic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants