New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix osu!taiko slider velocity being written incorrectly to .osu
file on export
#25689
Conversation
Judging by the amount of times we've had to touch this accursed thing and subsequently broke it in some accursed way? 100%. No matter how weird it looks. |
Hmm, it's basically going to be opening the editor, exporting to an |
Sure. If that covers the incorrect encoding then that works. |
Tests added! |
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
!diffcalc |
Apart from fixing the writing to the file, I've also made what I'd consider a huge code quality improvement:
Does this need test coverage? I'd argue not as now there is no special logic for taiko decode/encode whenSliderMultiplier
is concerned. Testing it would just look weird.