Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix osu!taiko slider velocity being written incorrectly to .osu file on export #25689

Merged
merged 11 commits into from
Dec 7, 2023
Merged

Fix osu!taiko slider velocity being written incorrectly to .osu file on export #25689

merged 11 commits into from
Dec 7, 2023

Commits on Dec 6, 2023

  1. Fix incorrect slider velocity being written on export for osu!taiko b… 

    …eatmaps
    @peppy
    peppy committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    b5bae56 View commit details
    Browse the repository at this point in the history

  2. Remove complex implementation of taiko SV multiplier

    @peppy
    peppy committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    1cb3c71 View commit details
    Browse the repository at this point in the history

  3. Reapply legacy taiko velocity multiplier in all relevant places

    @peppy
    peppy committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    8a0d152 View commit details
    Browse the repository at this point in the history

  4. Move constant local to taiko

    @peppy
    peppy committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    1b50d10 View commit details
    Browse the repository at this point in the history

  5. Remove pointless test

    @peppy
    peppy committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    51f9377 View commit details
    Browse the repository at this point in the history

  6. Revert "Remove pointless test" 

    This reverts commit 51f9377.
    @peppy
    peppy committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    01c6149 View commit details
    Browse the repository at this point in the history

  7. Add test coverage of correct multiplier written to .osu file

    @peppy
    peppy committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    853d67f View commit details
    Browse the repository at this point in the history

  8. Test multiple values, including default

    @peppy
    peppy committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    44beecb View commit details
    Browse the repository at this point in the history

  9. Remove unnecessary prefix 

    Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
    @peppy @bdach
    peppy and bdach committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    b8694ab View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Add more inline commenting around VELOCITY_MULTIPLIER application t… 

    …o `TimeRange`
    @peppy
    peppy committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    323808a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into taiko-multiplier-fix

    @bdach
    bdach committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    9e93ca9 View commit details
    Browse the repository at this point in the history