Toolbar design iteration #26168
Merged
Toolbar design iteration #26168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
force-pushed
the
toolbar-design-iteration
branch
from
538ff04
to
cf5e3e8
Compare
peppy
added
the
next release
bdach
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, had to.
Arguably we wouldn't be mixing pink and green, but i think it works quite nicely and going full green is probably not the look we want (I'd lean towards pink). At the same time, the rulesets looked ugly in pink, so this is a middle-ground.
Figma reference: https://www.figma.com/file/Oqr4fuKKCGfBtzzUP8Qdis/Volume-Slider?type=design&node-id=0-1&mode=design
Takes some inspiration from flyte's newer designs but also makes some changes I feel works well. Iterative and not final.
2023-12-28.04.09.50.mp4