Fix toolbar buttons not being clickable at screen edges #26530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joehuu
reviewed
Jan 15, 2024
| @@ -42,52 +42,59 @@ private void load(OsuConfigManager config) | |||
| clockDisplayMode = config.GetBindable<ToolbarClockDisplayMode>(OsuSetting.ToolbarClockDisplayMode); | |||
| prefer24HourTime = config.GetBindable<bool>(OsuSetting.Prefer24HourTime); | |||
|
|
|||
| Padding = new MarginPadding(3); | |||
|
|
|||
| Children = new Drawable[] | |||
There was a problem hiding this comment.
This was old code, but can make this Child for less indent.
|
I really hate how this feels but sure it's what people seem to want. |
peppy
approved these changes
Jan 15, 2024
peppy
added a commit
to peppy/osu
that referenced
this pull request
Jan 15, 2024
…target Fix toolbar buttons not being clickable at screen edges
dani211e
added a commit
to dani211e/osu-tools
that referenced
this pull request
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
out.mp4
The buttons are expanded so the currently padded region is also clickable. With this change, the buttons can be clicked at the very edge of the screen.
The PR simply nests the button content into a container and applies the padding there.
The only visual change is the position of the position of the tooltip text. I the new position aligns better with the button (I'm guessing the tooltip position change in the new design was unintentional):
masterAlso, on
master, the text is misaligned as the gamemode buttons have different padding (3f vs 5f).