Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timing point changes not applying after selecting another one #26585

Merged
merged 4 commits into from Jan 17, 2024

Conversation

frenzibyte
Copy link
Member

This is resolved by scheduling the switch in control point selection, since, at the moment that the user clicks and RowBackground handles the click (returning true in OnClick), focus lost event is rolled out to any focused text box and commit calls are made.

In master, control points are switched before the focus lost event is dispatched, causing the text box to commit to the new control point rather than the previously selected one.

By scheduling, focus lost events are dispatched first, then the control point is switched in the next frame.

Before:

CleanShot.2024-01-17.at.08.41.40.mp4

After:

CleanShot.2024-01-17.at.08.39.33.mp4

No idea why this is only in android, but okay.
@peppy peppy self-requested a review January 17, 2024 10:36
@peppy peppy merged commit 6a8a45b into ppy:master Jan 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timing point changes applying to newly-selected timing point rather than original
2 participants