Rewrite osu!taiko playfield adjustment container to keep playfield height constant #26631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I honestly don't have much clue about this one but doing so matches master.
1 task
1 task
peppy
reviewed
Jan 22, 2024
| Children = new Drawable[] | ||
| { | ||
| new Container | ||
| { | ||
| Name = "Elements before hit objects", | ||
| RelativeSizeAxes = Axes.Both, | ||
| FillMode = FillMode.Fit, |
There was a problem hiding this comment.
This line alone sells me on this PR.
peppy
reviewed
Jan 22, 2024
| Y = height; | ||
| Y = relativeHeight; | ||
|
|
||
| Scale = new Vector2(Math.Max((Parent!.ChildSize.Y / 768f) * (relativeHeight / base_relative_height), 1f)); |
There was a problem hiding this comment.
I'm pretty sure this can be simplified, but not going to attempt that until we're first in a good state (ie. your PRs merged + #25919 is resolved).
peppy
reviewed
Jan 22, 2024
|
As far as I can tell this visually looks exactly the same as on master. I checked it on multiple resolutions scales with my ultrawide monitor and second monitor. So seems good! I compared these two screenshots from master and this PR and the positioning is pixel perfect. |
|
As mentioned on discord, |
peppy
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This arose from #26615 and few discord discussions.
Up until now, osu!taiko's playfield scaling was completely dependent on each component inside it, which was suboptimal for essential components like the "input drum", requiring to set a fill aspect ratio to appear correctly across different game resolutions.
Not only was it an issue with sizing, but also with offsetting components. To properly have a constant gap applied between the input drum and the hit target position, the hit target would have to have an X position that's proportionate to the input drum's width (because the input drum's width changes based on the game resolution, because the playfield height changes based on the game resolution, etc.).
Not to mention
TaikoPlayfieldhaving to apply the container paddings per update andLegacyInputDrumneeding to scale itself.All of this is now gone and simplified by simply making
TaikoPlayfieldAdjustmentContainerdirectly upscale the playfield instead of changing its height.Worthy of note that despite everything seemingly working well, there are changes like fa2c33c which I'm frankly not 101% sure how they contribute to the correctness of the new logic, but it makes this PR match master on all different aspect ratios, therefore I pushed it.
Comparison with no mod (
osu!is latest release,osu!developmentis this PR):CleanShot.2024-01-20.at.00.29.50-converted.mp4
Comparison with classic mod:
CleanShot.2024-01-20.at.00.31.37-converted.mp4