Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move osu!taiko playfield down a nudge to match stable visually #26635

Merged
merged 3 commits into from Jan 26, 2024

Conversation

frenzibyte
Copy link
Member

@frenzibyte frenzibyte commented Jan 19, 2024

This one is just something I noticed. I'm not entirely sure where this offset is applied in stable's codebase, and it's quite hard to parse the layout system there, so I went with ballparking it like #26634.

Comparison:

CleanShot.2024-01-20.at.02.19.39.mp4

(notice playfield position roughly matches 1:1 between stable and lazer)

@peppy peppy self-requested a review January 26, 2024 09:16
@peppy
Copy link
Sponsor Member

peppy commented Jan 26, 2024

I'm not entirely sure where this offset is applied in stable's codebase, and it's quite hard to parse the layout system there, so I went with ballparking it like #26634.

You mustn't have searched far. It was literally one constant that matches perfectly, so I've changed to using that.

@peppy peppy merged commit 2778e43 into ppy:master Jan 26, 2024
2 checks passed
@frenzibyte frenzibyte deleted the shift-taiko-playfield branch January 26, 2024 10:53
@frenzibyte
Copy link
Member Author

Good find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants