Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix beatmap importing entering a bad state #2665

Merged
merged 17 commits into from May 31, 2018
Merged

Fix beatmap importing entering a bad state #2665

merged 17 commits into from May 31, 2018

Commits on May 29, 2018

  1. Add proper transaction rollback logic on exception

    @peppy
    peppy committed May 29, 2018
    Copy the full SHA
    2a87b85 View commit details
    Browse the repository at this point in the history

  2. Bring entity framework up-to-date and re-enable transactions

    @peppy
    peppy committed May 29, 2018
    Copy the full SHA
    d4e7f08 View commit details
    Browse the repository at this point in the history

  3. Improve transaction handling flexibility

    @peppy
    peppy committed May 29, 2018
    Copy the full SHA
    bcb04f6 View commit details
    Browse the repository at this point in the history

  4. Correctly rollback failed imports

    @peppy
    peppy committed May 29, 2018
    Copy the full SHA
    a3287b8 View commit details
    Browse the repository at this point in the history

  5. Don't start transactions for migration 

    It looks like transactions are used internally during migration.
    @peppy
    peppy committed May 29, 2018
    Copy the full SHA
    80806be View commit details
    Browse the repository at this point in the history

  6. Change order of event firing in Update calls 

    A remove event should not be fired before the update is successful.
    @peppy
    peppy committed May 29, 2018
    Copy the full SHA
    72da640 View commit details
    Browse the repository at this point in the history

  7. Fix loading test method returning oldest import rather than newest

    @peppy
    peppy committed May 29, 2018
    Copy the full SHA
    015fd9d View commit details
    Browse the repository at this point in the history

  8. Simplify test osz instantiation

    @peppy
    peppy committed May 29, 2018
    Copy the full SHA
    cc081ca View commit details
    Browse the repository at this point in the history

  9. Report any error during import to the write context to allow for roll… 

    …back
    @peppy
    peppy committed May 29, 2018
    Copy the full SHA
    3d3026a View commit details
    Browse the repository at this point in the history

  10. Add import rollback test

    @peppy
    peppy committed May 29, 2018
    Copy the full SHA
    203691b View commit details
    Browse the repository at this point in the history

  11. Add back missing rethrow

    @peppy
    peppy committed May 29, 2018
    Copy the full SHA
    c1f416b View commit details
    Browse the repository at this point in the history

  12. Report full error to log file

    @peppy
    peppy committed May 29, 2018
    Copy the full SHA
    4a18951 View commit details
    Browse the repository at this point in the history

  13. Fix event flushing sticking on early return

    @peppy
    peppy committed May 29, 2018
    Copy the full SHA
    31ab6f2 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2018

  1. Fix recycling never being performed due to incorrect ordering

    @peppy
    peppy committed May 30, 2018
    Copy the full SHA
    e23e2bd View commit details
    Browse the repository at this point in the history

  2. Recycle all contexts on beginning a write operation for the time being

    @peppy
    peppy committed May 30, 2018
    Copy the full SHA
    4a7de04 View commit details
    Browse the repository at this point in the history

  3. Remove performance optimisation tracking disables to keep things simp… 

    …le for now
    @peppy
    peppy committed May 30, 2018
    Copy the full SHA
    eb89317 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2018

  1. Merge branch 'master' into import-fixes

    @smoogipoo
    smoogipoo committed May 31, 2018
    Copy the full SHA
    a9db479 View commit details
    Browse the repository at this point in the history