Fix rotate tool button in editor disabled when selecting 1 circle #26702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inject osu ruleset specific rotate handler instead of generic handler.
…ton, then add disabling logic for rotate popover
…or rotation popover
bdach
requested changes
Jan 25, 2024
…m/honguyenminh/osu into fix-rotate-editor-button-disabled
honguyenminh
force-pushed
the
fix-rotate-editor-button-disabled
branch
from
537989c
to
6f78226
Compare
honguyenminh
commented
Mar 30, 2024
peppy
reviewed
Mar 31, 2024
Co-authored-by: Dean Herbert <pe@ppy.sh>
…m/honguyenminh/osu into fix-rotate-editor-button-disabled
peppy
reviewed
Apr 1, 2024
peppy
previously approved these changes
Apr 2, 2024
Joehuu
reviewed
Apr 2, 2024
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
peppy
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rotate button should now work when only 1 circle is selected, only playfield origin will be enabled while selection origin will be disabled.
EditorRadioButton is also untangled with the toolbox radio buttons.
Fixes #26247