Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rotate tool button in editor disabled when selecting 1 circle #26702

Merged
merged 18 commits into from
Apr 2, 2024

Update plurals in editor rotate button tooltip

6642702
Select commit
Failed to load commit list.
Sign in for the full log view
Merged

Fix rotate tool button in editor disabled when selecting 1 circle #26702

Update plurals in editor rotate button tooltip
6642702
Select commit
Failed to load commit list.
GitHub Actions / Test Results (macOS, MultiThreaded) failed Apr 2, 2024 in 0s

5727 passed, 3 failed and 52 skipped

Tests failed

❌ TestResults-macOS-MultiThreaded.trx

5782 tests were completed in 1584s with 5727 passed, 3 failed and 52 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Rulesets.Catch.Tests.Mods.TestSceneCatchModNoScope 3✅ 1❌ 14s
osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModFlashlight 13✅ 1❌ 15s
osu.Game.Rulesets.Osu.Tests.TestSceneCursorParticles 2✅ 1❌ 13s

❌ osu.Game.Rulesets.Catch.Tests.Mods.TestSceneCatchModNoScope

✅ TestAlwaysHidden
✅ TestConstructor
✅ TestVisibleAfterComboBreak
❌ TestVisibleDuringBreak
	TearDown : System.TimeoutException : "wait for catcher to hide" timed out

❌ osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModFlashlight

✅ TestComboBasedSize(False)
✅ TestComboBasedSize(True)
✅ TestConstructor
✅ TestFollowDelay(120)
✅ TestFollowDelay(1200)
✅ TestFollowDelay(600)
✅ TestPlayfieldBasedSize
✅ TestSizeMultiplier(0.5f)
✅ TestSizeMultiplier(1.0f)
✅ TestSizeMultiplier(1.5f)
✅ TestSizeMultiplier(2.0f)
✅ TestSliderDimsOnlyAfterStartTime
❌ TestSliderDoesDimAfterStartTimeIfHitEarly
	TearDown : System.TimeoutException : "test passed" timed out
✅ TestSliderDoesDimAfterStartTimeIfHitLate

❌ osu.Game.Rulesets.Osu.Tests.TestSceneCursorParticles

✅ TestConstructor
✅ TestLegacyBreakParticles
❌ TestLegacyKiaiParticles
	TearDown : System.TimeoutException : "wait for slider tracking" timed out

Annotations

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded)

osu.Game.Rulesets.Catch.Tests.Mods.TestSceneCatchModNoScope ► TestVisibleDuringBreak

Failed test found in:
  TestResults-macOS-MultiThreaded.trx
Error:
  TearDown : System.TimeoutException : "wait for catcher to hide" timed out
Raw output
TearDown : System.TimeoutException : "wait for catcher to hide" timed out
--TearDown
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.RunTestsFromNUnit()
   at InvokeStub_TestScene.RunTestsFromNUnit(Object, Object, IntPtr*)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModFlashlight ► TestSliderDoesDimAfterStartTimeIfHitEarly

Failed test found in:
  TestResults-macOS-MultiThreaded.trx
Error:
  TearDown : System.TimeoutException : "test passed" timed out
Raw output
TearDown : System.TimeoutException : "test passed" timed out
--TearDown
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.RunTestsFromNUnit()
   at InvokeStub_TestScene.RunTestsFromNUnit(Object, Object, IntPtr*)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.TestSceneCursorParticles ► TestLegacyKiaiParticles

Failed test found in:
  TestResults-macOS-MultiThreaded.trx
Error:
  TearDown : System.TimeoutException : "wait for slider tracking" timed out
Raw output
TearDown : System.TimeoutException : "wait for slider tracking" timed out
--TearDown
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.RunTestsFromNUnit()
   at InvokeStub_TestScene.RunTestsFromNUnit(Object, Object, IntPtr*)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)