Adjust slider tick / end defaults again #26703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
added
the
next release
bdach
requested changes
Jan 29, 2024
This reverts commit 6070eac.
peppy
force-pushed
the
smaller-slider-misses
branch
from
6a1542b
to
8341da7
Compare
peppy
commented
Jan 29, 2024
bdach
approved these changes
Jan 29, 2024
tick-indicators.mp4 |
bdach
added a commit
to bdach/osu
that referenced
this pull request
Jan 30, 2024
This reverts commit d0421fe and fixes ppy#26801. ppy#26703 (comment) was correct in saying that the early fade-out needs to be restored, and that's because of the early-return. Legacy judgements that are the temporary displayed judgement from new piece should also receive the fade-out, and d0421fe broke that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to improve the defaults until less people complain
More subtle, less noisy, but still should describe the misses quite well.
I toyed with bringing across the stable behaviour of ticks not fading out but people preferred this direction, so let's stick with it.
CleanShot.2024-01-25.at.10.35.03.mp4