Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display which mods grant pp #26934

Merged
merged 5 commits into from Feb 4, 2024
Merged

Display which mods grant pp #26934

merged 5 commits into from Feb 4, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Feb 1, 2024

In mod select and in song select footer.

2024-02-01.22-41-47.mp4

I'll quote the disclaimer from the issue again:

  • this is only a temporary UX solution to a real problem of users not knowing what currently gives PP and what doesn't.
  • The set of mods that will give pp is subject to change and will change (for the better) as we see fit.
  • There is no guarantee that the "ranked" mod concept will function indefinitely. The original goal was to have as much "ranked" as possible, and as far as I'm aware, this has not changed.

This doesn't work 100% correctly in multiplayer, namely when a user is selecting from free mods, but that is a pre-existing issue that affects the mod multiplier and the beatmap attribute display too so I'd ask to look away for the time being.

Please give f89923a particular attention when reviewing. And yes for now that commit is written very conservatively to match the server-side implementation (which the Ranked property will be replacing).

@cl8n
Copy link
Member

cl8n commented Feb 4, 2024

to me (edit: not just me, stable uses the "play-unranked" element like this)
"ranked"/"unranked" implies something about a score submitting to leaderboards at all, rather than just awarding pp, so the nomenclature is kind of confusing at a glance.

@bdach
Copy link
Collaborator Author

bdach commented Feb 4, 2024

I'm not sure what other naming to use for this.

@cl8n
Copy link
Member

cl8n commented Feb 4, 2024

something like "awards pp" or "pp enabled" would be more clear but I admit it reads a little clunky compared to current. I'm not sure either...

@peppy
Copy link
Sponsor Member

peppy commented Feb 4, 2024

I was going to mention this, but we might actually change these scores to not show on the leaderboard, just to keep things simple.

I think the language is fine for now from this angle.

Copy link
Sponsor Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine as a first step 👍

@peppy peppy merged commit c64d414 into ppy:master Feb 4, 2024
13 of 17 checks passed
@bdach bdach deleted the which-mods-for-pp branch February 5, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Display which mods grant pp in client
3 participants