Allow a few new mods and mod settings for pp #26935
Conversation
|
If caching isn't a concern here, I'd propose adding some more mods: BlindsLong long time ago pp for blinds was implemented so it's pretty much good to go RandomThis mod doesn't require any additional work diff/ppcalc side since it only moves objects around Mirror (osu!)Same as random, but I'd even say it's okay to make it not affect pp at all - difference in pp and difficulty is usually negligible NoscopePurely visual mod, shouldn't be accounted in pp at all If you're only "ranking" mods that don't affect difficulty at all then you can add just the last two |
|
Blinds, random and mirror are 100% a no-go right now. We're not calculating difficulty attributes on the fly. |
|
Blinds isn't affecting diffcalc -it's completely in pp calc |
The mod does impact pp, but it requires no extra difficulty attributes (ppy#26935 (comment)).
Deemed as not affecting difficulty or pp in ppy#26935 (comment), so can be treated pretty much as nomod.
|
Alright I've applied for the two mods that can be applied right now. |
IMod.Rankedproperty from game to determine eligibility of score for pp osu-queue-score-statistics#218Allow pp for "Restart on fail" setting of Sudden Death & Perfect (c114fd8)
Closes #26844.
Allow pp for Accuracy Challenge (96f66aa)
Addresses #26919.
Allow pp for "Adjust pitch" setting of Half Time / Double Time (ea76f7a)
Addresses https://discord.com/channels/188630481301012481/1097318920991559880/1202606638951825459.
Allow pp for Blinds (a84f53b)
The mod does impact pp, but it requires no extra difficulty attributes (#26935 (comment)).
Allow pp for No Scope (8df593a)
As per #26935 (comment).