Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiplayer match screen #2708

Merged
merged 23 commits into from
Jun 21, 2018
Merged

Multiplayer match screen #2708

merged 23 commits into from
Jun 21, 2018

Conversation

DrabWeb
Copy link
Member

@DrabWeb DrabWeb commented Jun 1, 2018

image

Only the basic UI for now, proper functionality to come later.

Partially implements #2723.

@peppy
Copy link
Sponsor Member

peppy commented Jun 2, 2018

Is this one based off a flyte design? If so, best to link the issue or at least a png for comparison.

@DrabWeb
Copy link
Member Author

DrabWeb commented Jun 3, 2018

multiplayer_settings_c

Probably should've created an issue for this beforehand, sorry. Will remember next time.

@DrabWeb DrabWeb mentioned this pull request Jun 3, 2018
@peppy peppy removed this from the June 2018 milestone Jun 3, 2018
@peppy
Copy link
Sponsor Member

peppy commented Jun 21, 2018

I think this is okay to merge now. Would rather avoid PRs of this size in the future; it's very hard to review.

Also with the testing of users and what not, I think we should make central seeders so they aren't being specified all over the test cases. ie. userSeeder.GetUser() would keep returning fresh users with avatars etc. populated, rather than all these inline strings and user blocks in test cases making them long to review and hard to visually parse.

@peppy peppy merged commit bf9b210 into ppy:master Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants