New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow pp for muted mod for any combination of settings #27144
Conversation
ModMuted
to ranked when setting adjustedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably fine to allow. From a balance standpoint the biggest reservations I'd have is metronome, and that's enabled by default which means we allow it already soo....
If anything metronome off could be considered harder but not sure pp is the correct place to be gauging that anyhow. Might request review from pp committee just to see if there's agreement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say metronome is a tiny bit easier to click to on some maps, but after testing I couldn't find any way to use it to my advantage because it quickly gets muted and replaced with the song on any combo settings and any miss throws you off way more than you get from the metronome at the start of the map. So yeah, I'd say its fine to have all settings ranked
I'm not ready to merge this until one full SR/PP recalc using lazer's processor has completed. |
Muted isn't being accounted for in sr/pp at all, so it shouldn't affect difficulty unless there's something fundamentally broken |
I'm not sure why this is a requirement if it wasn't for #26935. Or why the mod was enabled at all in the first place even, if this is somehow a concern. |
I'd say blinds was more important to test than this indeed, since it actually affects pp |
I did do a quick-and-dirty test for blinds locally and it did appear to work correctly. |
if you think that metronome can create advantage - think about possibility of mp3 editing |
Note: will require game package bump and deploy in |
ModMuted was enable ranked in ppy/osu-queue-score-statistics#9
the reason is "it doesn't change gameplay"
so can we make ModMuted ranked when adjust settings