Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple issues causing database reset to fail #2726

Merged
merged 3 commits into from
Jun 6, 2018

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Jun 3, 2018

  • Closes database connection if initial startup command fails (main cause of issue).
  • Avoids leaking locks
  • Forces GC before attempting to delete the file.

Closes #2675.
Closes #2571.
Closes #2712.
Closes #2404.

DrabWeb
DrabWeb previously approved these changes Jun 6, 2018
@peppy peppy added the priority:0 Showstopper. Critical to the next release. label Jun 6, 2018
cmd.CommandText = "PRAGMA journal_mode=WAL;";
cmd.ExecuteNonQuery();
connection.Close();
throw;

This comment was marked as off-topic.

This comment was marked as off-topic.

smoogipoo
smoogipoo previously approved these changes Jun 6, 2018
@peppy peppy dismissed stale reviews from smoogipoo and DrabWeb via a60c888 June 6, 2018 13:05
@peppy peppy merged commit 1d5a773 into ppy:master Jun 6, 2018
@peppy peppy deleted the fix-database-migration-failure branch June 21, 2018 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:0 Showstopper. Critical to the next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants