Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ruleset medals not displaying due to deserialisation failure #27574

Merged
merged 1 commit into from
Mar 11, 2024

Fix ruleset medals not displaying due to deserialisation failure

f30dfcb
Select commit
Failed to load commit list.
Sign in for the full log view
Merged

Fix ruleset medals not displaying due to deserialisation failure #27574

Fix ruleset medals not displaying due to deserialisation failure
f30dfcb
Select commit
Failed to load commit list.
GitHub Actions / Test Results (macOS, MultiThreaded) failed Mar 11, 2024 in 0s

5644 passed, 2 failed and 52 skipped

Tests failed

❌ TestResults-macOS-MultiThreaded.trx

5698 tests were completed in 1516s with 5644 passed, 2 failed and 52 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Rulesets.Catch.Tests.Mods.TestSceneCatchModNoScope 3✅ 1❌ 14s
osu.Game.Tests.Visual.Gameplay.TestSceneGameplaySamplePlayback 1✅ 1❌ 2s

❌ osu.Game.Rulesets.Catch.Tests.Mods.TestSceneCatchModNoScope

✅ TestAlwaysHidden
✅ TestConstructor
✅ TestVisibleAfterComboBreak
❌ TestVisibleDuringBreak
	TearDown : System.TimeoutException : "wait for catcher to hide" timed out

❌ osu.Game.Tests.Visual.Gameplay.TestSceneGameplaySamplePlayback

❌ TestAllSamplesStopDuringSeek
	TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : sample playback still disabled
✅ TestConstructor

Annotations

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded)

osu.Game.Rulesets.Catch.Tests.Mods.TestSceneCatchModNoScope ► TestVisibleDuringBreak

Failed test found in:
  TestResults-macOS-MultiThreaded.trx
Error:
  TearDown : System.TimeoutException : "wait for catcher to hide" timed out
Raw output
TearDown : System.TimeoutException : "wait for catcher to hide" timed out
--TearDown
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.RunTestsFromNUnit()
   at InvokeStub_TestScene.RunTestsFromNUnit(Object, Object, IntPtr*)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 0 in TestResults-macOS-MultiThreaded.trx

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded)

osu.Game.Tests.Visual.Gameplay.TestSceneGameplaySamplePlayback ► TestAllSamplesStopDuringSeek

Failed test found in:
  TestResults-macOS-MultiThreaded.trx
Error:
  TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : sample playback still disabled
Raw output
TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : sample playback still disabled
--TearDown
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Threading.GameThread.<createThread>g__runWork|66_0()
   at System.Threading.Thread.StartHelper.Callback(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)